Closed
Conversation
meta-cla
bot
added
the
CLA Signed
|
@tsaichien has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91264901. |
meta-codesync
bot
changed the title
tryGetMutableBuffer APItryGetMutableBuffer API (#55943)
meta-codesync
bot
force-pushed
the
export-D91264901
branch
from
fd8b9d5 to
df26b3b
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 16, 2026
Summary: Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook/hermes#1578 Reviewed By: tmikov Differential Revision: D91264901
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
Summary: Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook/hermes#1578 Reviewed By: tmikov Differential Revision: D91264901
meta-codesync
bot
force-pushed
the
export-D91264901
branch
from
df26b3b to
ad78cab
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
Summary: Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook/hermes#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901
meta-codesync
bot
force-pushed
the
export-D91264901
branch
from
ad78cab to
93b35e5
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
Summary: Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook/hermes#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901
meta-codesync
bot
force-pushed
the
export-D91264901
branch
from
93b35e5 to
3b11a1f
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
Summary: Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook/hermes#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901
meta-codesync
bot
force-pushed
the
export-D91264901
branch
from
3b11a1f to
100aca9
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
Summary: Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook/hermes#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901
meta-codesync
bot
force-pushed
the
export-D91264901
branch
from
100aca9 to
cf01afa
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
Summary: Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook/hermes#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901
meta-codesync
bot
force-pushed
the
export-D91264901
branch
from
cf01afa to
e2bd74c
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Mar 19, 2026
Summary: Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook/hermes#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Mar 30, 2026
Summary: Pull Request resolved: facebook#56156 Pull Request resolved: facebook#55943 Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook/hermes#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Mar 31, 2026
Summary: Pull Request resolved: facebook#56156 Pull Request resolved: facebook#55943 Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook/hermes#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Apr 14, 2026
Summary: Pull Request resolved: facebook#56156 Pull Request resolved: facebook#55943 Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook/hermes#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901
meta-codesync
bot
force-pushed
the
export-D91264901
branch
3 times, most recently
from
c2b13d5 to
85f48b8
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Apr 15, 2026
Summary: Pull Request resolved: facebook#56156 Pull Request resolved: facebook#55943 Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook/hermes#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901
Summary: After reviewing the feasibility of adding new Runtime functionality, we realized the current state of `Runtime` makes it hard/inconvenient to add new basic functionality. It requires creating a new interface (e.g. `IRuntime2`) to declare the new APIs. Then, everywhere it is needed, both the original `Runtime` and `IRuntime2` needs to passed in to access both APIs. After discussion, we decided to introduce `IRuntime`, which will declare most of the `Runtime` functionalities. All "protected" APIs, which made sense before interfaces were introduced, will now be public. The protected static methods of `Runtime` will remain as is for the Friends to access. After we decided to cut "stable" (after incoming JSI improvements), new functionalities will be added in `IRuntime2` interface. `IRuntime2` will inherit `IRuntime` to make existing functionality easy to access. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D89093651
Summary: Currently, the size of a jsi `Array` is immutable. Once the `Array` is created, users can only set the element at an existing index, but not append to it. This change adds an `Array::push` API to improve ergonomics. The default implementation is also provided in `jsi::Runtime` Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D82254334
Summary: Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook/hermes#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901
meta-codesync
bot
force-pushed
the
export-D91264901
branch
from
85f48b8 to
87c41c0
Compare
meta-codesync bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Apr 15, 2026
Summary: X-link: facebook/react-native#56156 X-link: facebook/react-native#55943 Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: #1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901 fbshipit-source-id: 7edd66adae16551b64222c834d3fc211f7c88622
meta-codesync bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Apr 15, 2026
Summary: X-link: facebook/react-native#56156 X-link: facebook/react-native#55943 Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: #1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901 fbshipit-source-id: 7edd66adae16551b64222c834d3fc211f7c88622
meta-codesync bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Apr 15, 2026
Summary: X-link: facebook/react-native#56156 X-link: facebook/react-native#55943 Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: #1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901 fbshipit-source-id: 7edd66adae16551b64222c834d3fc211f7c88622
|
This pull request has been merged in 79843fc. |
tsaichien
added a commit
to tsaichien/hermes
that referenced
this pull request
Apr 15, 2026
Summary: X-link: facebook/react-native#56156 X-link: facebook/react-native#55943 Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901 fbshipit-source-id: 7edd66adae16551b64222c834d3fc211f7c88622
tsaichien
added a commit
to tsaichien/hermes
that referenced
this pull request
Apr 15, 2026
Summary: X-link: facebook/react-native#56156 X-link: facebook/react-native#55943 Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901 fbshipit-source-id: 7edd66adae16551b64222c834d3fc211f7c88622
tsaichien
added a commit
to tsaichien/hermes
that referenced
this pull request
Apr 15, 2026
Summary: X-link: facebook/react-native#56156 X-link: facebook/react-native#55943 Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901 fbshipit-source-id: 7edd66adae16551b64222c834d3fc211f7c88622
tsaichien
added a commit
to tsaichien/hermes
that referenced
this pull request
Apr 15, 2026
Summary: X-link: facebook/react-native#56156 X-link: facebook/react-native#55943 Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901 fbshipit-source-id: 7edd66adae16551b64222c834d3fc211f7c88622
tsaichien
added a commit
to tsaichien/hermes
that referenced
this pull request
Apr 16, 2026
Summary: X-link: facebook/react-native#56156 X-link: facebook/react-native#55943 Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook#1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901 fbshipit-source-id: 7edd66adae16551b64222c834d3fc211f7c88622
tsaichien
added a commit
to facebook/hermes
that referenced
this pull request
Apr 16, 2026
Summary: X-link: facebook/react-native#56156 X-link: facebook/react-native#55943 Adds `ArrayBuffer::tryGetMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The returned buffer will point directly into the same buffer as the runtime object, rather than copying it out. The data referencedby the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: #1578 Changelog: [Internal] Reviewed By: tmikov Differential Revision: D91264901 fbshipit-source-id: 7edd66adae16551b64222c834d3fc211f7c88622
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds
ArrayBuffer::tryGetMutableBufferto JSI. This allows the user toretrieve a
MutableBufferfrom theArrayBuffer. The returned bufferwill point directly into the same buffer as the runtime object, rather than
copying it out.
The data referencedby the
MutableBufferwill be alive during the entiretyof the
MutableBufferlifespan.Addresses: facebook/hermes#1578
Reviewed By: tmikov
Differential Revision: D91264901