Add spring animation Fantom integration tests#56106
Open
sammy-SC wants to merge 1 commit intofacebook:mainfrom
Open
Add spring animation Fantom integration tests#56106sammy-SC wants to merge 1 commit intofacebook:mainfrom
sammy-SC wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Changelog: [Internal] Add 3 Fantom integration tests for `Animated.spring` targeting `SpringAnimationDriver.cpp` (0% → 89.4% line coverage): - **basic spring animation**: underdamped spring (stiffness=100, damping=10), verifies mid-animation progress, final value, and finish callback - **overshoot clamping**: highly underdamped spring (stiffness=300, damping=5) with `overshootClamping: true`, samples 25 points to assert value never exceeds toValue — exercises `isOvershooting()` and clamping branches - **critically damped**: damping=20 (zeta=1.0), verifies monotonic convergence without oscillation — exercises overdamped/critically damped branch in `getValueAndVelocityForTime()` Reviewed By: cortinico Differential Revision: D95058965
meta-cla
Bot
added
the
CLA Signed
cortinico
approved these changes
Mar 16, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Add 3 Fantom integration tests for
Animated.springtargetingSpringAnimationDriver.cpp(0% → 89.4% line coverage):verifies mid-animation progress, final value, and finish callback
with
overshootClamping: true, samples 25 points to assert value neverexceeds toValue — exercises
isOvershooting()and clamping brancheswithout oscillation — exercises overdamped/critically damped branch in
getValueAndVelocityForTime()Reviewed By: cortinico
Differential Revision: D95058965