Migrate BlobModule to TurboModuleWithJSIBindings for safe JSI access (#56272)#56272
Closed
javache wants to merge 1 commit intofacebook:mainfrom
Closed
Migrate BlobModule to TurboModuleWithJSIBindings for safe JSI access (#56272)#56272javache wants to merge 1 commit intofacebook:mainfrom
javache wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
meta-codesync
bot
changed the title
javache
force-pushed
the
export-D98712509
branch
from
8345c0b to
fd9bb0b
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 8, 2026
…acebook#56272) Summary: BlobCollector::nativeInstall received a raw jlong pointer to jsi::Runtime from Java and cast it directly, with no thread safety. Migrated BlobModule to implement TurboModuleWithJSIBindings, which provides a safe getBindingsInstaller() callback guaranteed to run on the JS thread during module initialization. Removed the unsafe raw pointer path. Changelog: [Internal] Reviewed By: alanleedev Differential Revision: D98712509
javache
force-pushed
the
export-D98712509
branch
2 times, most recently
from
00ec4e4 to
61946a5
Compare
…acebook#56272) Summary: Pull Request resolved: facebook#56272 BlobCollector::nativeInstall received a raw jlong pointer to jsi::Runtime from Java and cast it directly, with no thread safety. Migrated BlobModule to implement TurboModuleWithJSIBindings, which provides a safe getBindingsInstaller() callback guaranteed to run on the JS thread during module initialization. Removed the unsafe raw pointer path. Changelog: [Internal] Reviewed By: alanleedev Differential Revision: D98712509
javache
force-pushed
the
export-D98712509
branch
from
61946a5 to
5f0c857
Compare
|
This pull request has been merged in b20d7fc. |
Collaborator
|
This pull request was successfully merged by @javache in b20d7fc When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
BlobCollector::nativeInstall received a raw jlong pointer to jsi::Runtime from Java and cast it directly, with no thread safety. Migrated BlobModule to implement TurboModuleWithJSIBindings, which provides a safe getBindingsInstaller() callback guaranteed to run on the JS thread during module initialization. Removed the unsafe raw pointer path.
Changelog: [Internal]
Reviewed By: alanleedev
Differential Revision: D98712509