[GENERAL][FIXED] - Fix WHATWG spec violations in URL and URLSearchParams polyfills#56327
Open
w3di wants to merge 1 commit intofacebook:mainfrom
Open
[GENERAL][FIXED] - Fix WHATWG spec violations in URL and URLSearchParams polyfills#56327w3di wants to merge 1 commit intofacebook:mainfrom
w3di wants to merge 1 commit intofacebook:mainfrom
Conversation
…ams polyfills Summary: Three spec violations in the URL/URLSearchParams polyfills: 1. URLSearchParams.size returned the number of unique keys (Map.size) instead of the total number of name-value pairs per the WHATWG spec. 2. URLSearchParams string constructor split on every '=' character, dropping parts of values that contain '='. Only the first '=' should be treated as a key-value separator. 3. URL.hash getter used a regex that stopped at '/', breaking fragment identifiers like #/users/123 common in SPA routing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three spec violations in the
URLandURLSearchParamspolyfills (Libraries/Blob/):URLSearchParams.sizereturned the number of unique keys (Map.size) instead of the total number of name-value pairs. Per WHATWG spec,.sizemust return the list's total size.URLSearchParamsstring constructor split on every=character, silently dropping parts of values containing=(e.g. base64 tokens, JWTs). Per WHATWG spec, only the first=is the key-value separator.URL.hashgetter used a regex/#([^/]*)/that stopped matching at/, breaking fragment identifiers like#/users/123common in SPA hash-routing. Per WHATWG spec, the hash includes everything from#to end of string.Changelog:
[General] [Fixed] - Fix WHATWG spec violations in URL and URLSearchParams polyfills
Test Plan
URLSearchParamsconstructed from array with duplicate keys now expectssizeto be3(total pairs) instead of2(unique keys).yarn jest packages/react-native/Libraries/Blob/__tests__/URL-test.js