[General] [Fixed] - Fix missing format specifier in renderApplication invariant#56329
Open
w3di wants to merge 1 commit intofacebook:mainfrom
Open
[General] [Fixed] - Fix missing format specifier in renderApplication invariant#56329w3di wants to merge 1 commit intofacebook:mainfrom
w3di wants to merge 1 commit intofacebook:mainfrom
Conversation
… invariant The invariant call passes rootTag as a substitution argument but the format string has no %s placeholder, so the error message never shows the actual value of rootTag.
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
invariantcall inrenderApplicationpassesrootTagas a substitution argument, but the format string has no%splaceholder. When the invariant fails, the error message reads:instead of:
The value is silently dropped, making the error less useful for debugging.
Changelog:
[General] [Fixed] - Fix missing format specifier in renderApplication invariant
Test Plan
invariantdirectly: without%sthe third argument is ignored, with%sit is substituted into the message.