Skip to content

Exclude deprecated and internal categories from the ReactApple C++ snapshot. (#56351)#56351

Closed
coado wants to merge 4 commits intofacebook:mainfrom
coado:export-D99838922
Closed

Exclude deprecated and internal categories from the ReactApple C++ snapshot. (#56351)#56351
coado wants to merge 4 commits intofacebook:mainfrom
coado:export-D99838922

Conversation

@coado
Copy link
Copy Markdown
Contributor

@coado coado commented Apr 7, 2026

Summary:

Excludes categories marked as Deprecated and Internal from the ReactApple C++ public API snapshots.

Changelog:
[Internal]

Reviewed By: huntie

Differential Revision: D99838922

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2026
@facebook-github-tools facebook-github-tools bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Apr 7, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Apr 7, 2026

@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99838922.

@meta-codesync meta-codesync bot changed the title Exclude deprecated and internal categories from the ReactApple C++ snapshot. Exclude deprecated and internal categories from the ReactApple C++ snapshot. (#56351) Apr 8, 2026
@coado coado force-pushed the export-D99838922 branch from 6c06fad to 134fe09 Compare April 8, 2026 10:41
coado added a commit to coado/react-native that referenced this pull request Apr 8, 2026
…apshot. (facebook#56351)

Summary:

Excludes categories marked as `Deprecated` and `Internal` from the ReactApple C++ public API snapshots.

Changelog:
[Internal]

Reviewed By: huntie

Differential Revision: D99838922
coado added a commit to coado/react-native that referenced this pull request Apr 8, 2026
…apshot. (facebook#56351)

Summary:
Pull Request resolved: facebook#56351

Excludes categories marked as `Deprecated` and `Internal` from the ReactApple C++ public API snapshots.

Changelog:
[Internal]

Reviewed By: huntie

Differential Revision: D99838922
@coado coado force-pushed the export-D99838922 branch from 134fe09 to a0b8750 Compare April 8, 2026 10:45
Dawid Małecki added 3 commits April 8, 2026 04:39
Summary:
Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot.

Changelog:
[Internal]

Differential Revision: D99434605
Summary:
Excludes all symbols and members that consists of `DO_NOT_USE`, like

- findComponentViewWithTag_DO_NOT_USE_DEPRECATED
- propKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN
- setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN
- findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN
- componentViewName_DO_NOT_USE_THIS_IS_BROKEN
- ensurePlaceholderIfEmpty_DO_NOT_USE

Changelog:
[Internal]

Differential Revision: D99834673
Summary:
Excludes symbols  marked as `deprecated`, such as:

- viewRegistry_DEPRECATED
- DEPRECATED_sendUpdatedChildFrames
- nativeProps_DEPRECATED
- findShadowNodeByTag_DEPRECATED
- setNativeProps_DEPRECATED

from the C++ public API snapshot.

Differential Revision: D99838523
coado added a commit to coado/react-native that referenced this pull request Apr 8, 2026
…apshot. (facebook#56351)

Summary:

Excludes categories marked as `Deprecated` and `Internal` from the ReactApple C++ public API snapshots.

Changelog:
[Internal]

Reviewed By: huntie

Differential Revision: D99838922
@coado coado force-pushed the export-D99838922 branch from a0b8750 to ceefb7e Compare April 8, 2026 11:45
…apshot. (facebook#56351)

Summary:
Pull Request resolved: facebook#56351

Excludes categories marked as `Deprecated` and `Internal` from the ReactApple C++ public API snapshots.

Changelog:
[Internal]

Reviewed By: huntie

Differential Revision: D99838922
@coado coado force-pushed the export-D99838922 branch from ceefb7e to 8c62fb3 Compare April 8, 2026 11:51
@meta-codesync meta-codesync bot closed this in f5326c9 Apr 9, 2026
@facebook-github-tools facebook-github-tools bot added the Merged This PR has been merged. label Apr 9, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Apr 9, 2026

This pull request has been merged in f5326c9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant