Exclude deprecated and internal categories from the ReactApple C++ snapshot. (#56351)#56351
Closed
coado wants to merge 4 commits intofacebook:mainfrom
Closed
Exclude deprecated and internal categories from the ReactApple C++ snapshot. (#56351)#56351coado wants to merge 4 commits intofacebook:mainfrom
coado wants to merge 4 commits intofacebook:mainfrom
Conversation
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 8, 2026
…apshot. (facebook#56351) Summary: Excludes categories marked as `Deprecated` and `Internal` from the ReactApple C++ public API snapshots. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99838922
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 8, 2026
…apshot. (facebook#56351) Summary: Pull Request resolved: facebook#56351 Excludes categories marked as `Deprecated` and `Internal` from the ReactApple C++ public API snapshots. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99838922
added 3 commits
April 8, 2026 04:39
Summary: Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Differential Revision: D99434605
Summary: Excludes all symbols and members that consists of `DO_NOT_USE`, like - findComponentViewWithTag_DO_NOT_USE_DEPRECATED - propKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN - setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN - findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN - componentViewName_DO_NOT_USE_THIS_IS_BROKEN - ensurePlaceholderIfEmpty_DO_NOT_USE Changelog: [Internal] Differential Revision: D99834673
Summary: Excludes symbols marked as `deprecated`, such as: - viewRegistry_DEPRECATED - DEPRECATED_sendUpdatedChildFrames - nativeProps_DEPRECATED - findShadowNodeByTag_DEPRECATED - setNativeProps_DEPRECATED from the C++ public API snapshot. Differential Revision: D99838523
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 8, 2026
…apshot. (facebook#56351) Summary: Excludes categories marked as `Deprecated` and `Internal` from the ReactApple C++ public API snapshots. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99838922
…apshot. (facebook#56351) Summary: Pull Request resolved: facebook#56351 Excludes categories marked as `Deprecated` and `Internal` from the ReactApple C++ public API snapshots. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99838922
|
This pull request has been merged in f5326c9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Excludes categories marked as
DeprecatedandInternalfrom the ReactApple C++ public API snapshots.Changelog:
[Internal]
Reviewed By: huntie
Differential Revision: D99838922