Don't update mounted flag on React revision#56371
Closed
j-piasecki wants to merge 1 commit intofacebook:mainfrom
Closed
Don't update mounted flag on React revision#56371j-piasecki wants to merge 1 commit intofacebook:mainfrom
j-piasecki wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Changelog: [GENERAL][FIXED] - Prevent updates to mounted flag on the React revision Currently, with fabric branching enabled, the logic for `updateMountedFlag` can run twice for the same tree: first when committing it to a react revision, then when merging to the main revision. This has the potential to drive `enableCounter_ ` negative. This diff, makes it so that `updateMountedFlag` runs only when committing to the main branch. Differential Revision: D99996551
meta-cla
bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99996551. |
facebook-github-tools
bot
added
p: Software Mansion
|
This pull request has been merged in 7ee893d. |
Collaborator
|
This pull request was successfully merged by @j-piasecki in 7ee893d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [GENERAL][FIXED] - Prevent updates to mounted flag on the React revision
Currently, with fabric branching enabled, the logic for
updateMountedFlagcan run twice for the same tree: first when committing it to a react revision, then when merging to the main revision. This has the potential to driveenableCounter_negative.This diff, makes it so that
updateMountedFlagruns only when committing to the main branch.Differential Revision: D99996551