Skip to content

Handle missing viewState gracefully in SurfaceMountingManager.addViewAt #56376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cortinico wants to merge 1 commit into from
+16 −2
Closed

Handle missing viewState gracefully in SurfaceMountingManager.addViewAt #56376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions ...e/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,15 +282,29 @@ internal constructor(
return
}

val parentViewState = getViewState(parentTag)
val parentViewState = getNullableViewState(parentTag)
if (parentViewState == null) {
ReactSoftExceptionLogger.logSoftException(
ReactSoftExceptionLogger.Categories.SURFACE_MOUNTING_MANAGER_MISSING_VIEWSTATE,
ReactNoCrashSoftException("Unable to find viewState for tag: [$parentTag] for addViewAt"),
)
return
}
if (parentViewState.view !is ViewGroup) {
val message =
"Unable to add a view into a view that is not a ViewGroup. ParentTag: $parentTag - Tag: $tag - Index: $index"
FLog.e(TAG, message)
throw IllegalStateException(message)
}
val parentView = parentViewState.view as ViewGroup
val viewState = getViewState(tag)
val viewState = getNullableViewState(tag)
if (viewState == null) {
ReactSoftExceptionLogger.logSoftException(
ReactSoftExceptionLogger.Categories.SURFACE_MOUNTING_MANAGER_MISSING_VIEWSTATE,
ReactNoCrashSoftException("Unable to find viewState for tag: [$tag] for addViewAt"),
)
return
}
val view = viewState.view
checkNotNull(view) { "Unable to find view for viewState $viewState and tag $tag" }

Expand Down
Loading