Roll out enableAndroidLinearText entirely (#56409)#56409
Closed
Abbondanzo wants to merge 1 commit intofacebook:mainfrom
Closed
Roll out enableAndroidLinearText entirely (#56409)#56409Abbondanzo wants to merge 1 commit intofacebook:mainfrom
enableAndroidLinearText entirely (#56409)#56409Abbondanzo wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100213385. |
enableAndroidLinearText entirelyenableAndroidLinearText entirely (#56409)
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Apr 10, 2026
Summary: The `enableAndroidLinearText` flag enables `Paint.LINEAR_TEXT_FLAG` wherever `SUBPIXEL_TEXT_FLAG` is already set. The flag defaults to `true` and has been fully rolled out internally, so this removes the flag and makes the behavior unconditional. Two call sites: - `CustomStyleSpan.kt`: always sets `isLinearText = true` alongside `isSubpixelText = true` - `ReactEditText.kt`: always toggles `LINEAR_TEXT_FLAG` in sync with `SUBPIXEL_TEXT_FLAG` The flag definition is removed from `ReactNativeFeatureFlags.config.js` and all generated accessor files are regenerated. Changelog: [Internal] Reviewed By: alanleedev Differential Revision: D100213385
18632fa to
c8edba4
Compare
Summary: Pull Request resolved: facebook#56409 The `enableAndroidLinearText` flag enables `Paint.LINEAR_TEXT_FLAG` wherever `SUBPIXEL_TEXT_FLAG` is already set. The flag defaults to `true` and has been fully rolled out internally, so this removes the flag and makes the behavior unconditional. Two call sites: - `CustomStyleSpan.kt`: always sets `isLinearText = true` alongside `isSubpixelText = true` - `ReactEditText.kt`: always toggles `LINEAR_TEXT_FLAG` in sync with `SUBPIXEL_TEXT_FLAG` The flag definition is removed from `ReactNativeFeatureFlags.config.js` and all generated accessor files are regenerated. Changelog: [Internal] Reviewed By: alanleedev Differential Revision: D100213385
c8edba4 to
2e6c169
Compare
|
This pull request has been merged in abd6173. |
Collaborator
|
This pull request was successfully merged by @Abbondanzo in abd6173 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
enableAndroidLinearTextflag enablesPaint.LINEAR_TEXT_FLAGwhereverSUBPIXEL_TEXT_FLAGis already set. The flag defaults totrueand has been fully rolled out internally, so this removes the flag and makes the behavior unconditional.Two call sites:
CustomStyleSpan.kt: always setsisLinearText = truealongsideisSubpixelText = trueReactEditText.kt: always togglesLINEAR_TEXT_FLAGin sync withSUBPIXEL_TEXT_FLAGThe flag definition is removed from
ReactNativeFeatureFlags.config.jsand all generated accessor files are regenerated.Changelog: [Internal]
Reviewed By: alanleedev
Differential Revision: D100213385