Prevent double calls to setMounted when merging a JS revision#56424
Closed
j-piasecki wants to merge 1 commit intofacebook:mainfrom
Closed
Prevent double calls to setMounted when merging a JS revision#56424j-piasecki wants to merge 1 commit intofacebook:mainfrom
setMounted when merging a JS revision#56424j-piasecki wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Changelog: [GENERAL][FIXED] Fixed double `setMounted` flag calls with fabric branching enabled This change removes the commit source condition from the call site in `ShadowTree::tryCommit` and moves the logic into updateMountedFlag itself: - Mounted flags are skipped for ReactRevisionMerge commits because they were already set during the React branch commit. Setting them again would double increment the EventEmitter's additive enable counter. - Runtime shadow node references updates condition didn't change, only moved to a single variable. - When neither operation is needed, the function returns early to avoid an unnecessary tree traversal under the DispatchMutex. Differential Revision: D100125886
meta-cla
bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100125886. |
facebook-github-tools
bot
added
p: Software Mansion
Collaborator
|
This pull request was successfully merged by @j-piasecki in a9a0000 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in a9a0000. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [GENERAL][FIXED] Fixed double
setMountedflag calls with fabric branching enabledThis change removes the commit source condition from the call site in
ShadowTree::tryCommitand moves the logic into updateMountedFlag itself:Differential Revision: D100125886