Skip to content

Add Android 17 safety comment for JNI-written static field #56442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alanleedev wants to merge 1 commit into from
+3 −0
Closed

Add Android 17 safety comment for JNI-written static field #56442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...tive/ReactAndroid/src/main/java/com/facebook/react/modules/appearance/AppearanceModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,9 @@ constructor(
public const val NAME: String = NativeAppearanceSpec.NAME
private const val APPEARANCE_CHANGED_EVENT_NAME = "appearanceChanged"

// Must remain `var` (not `val`) — this field is set from JNI in
// configurePlatformColorCacheInvalidationHook.cpp. Android 17+ crashes
// if JNI modifies a static final field (which `val` compiles to).
@DoNotStrip private var invalidatePlatformColorCache: Runnable? = null
}
}
Loading