Use relevant revision as base when updating mounted flag with branching enabled#56446
Closed
j-piasecki wants to merge 1 commit intofacebook:mainfrom
Closed
Use relevant revision as base when updating mounted flag with branching enabled#56446j-piasecki wants to merge 1 commit intofacebook:mainfrom
j-piasecki wants to merge 1 commit intofacebook:mainfrom
Conversation
…ng enabled Summary: Changelog: [GENERAL][FIXED] Uses relevant revision as base for mounted flag updates Similarly to the commit itself, which is already handled above, `updateMountedFlag` should be using relevant revision to compare the new tree. During react commits, it should compare to the react revision if it exists, and the main revision in all other cases. Differential Revision: D100800154
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100800154. |
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
p: Software Mansion
Collaborator
|
This pull request was successfully merged by @j-piasecki in 4b954e1 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [GENERAL][FIXED] Uses relevant revision as base for mounted flag updates
Similarly to the commit itself, which is already handled above,
updateMountedFlagshould be using relevant revision to compare the new tree. During react commits, it should compare to the react revision if it exists, and the main revision in all other cases.Differential Revision: D100800154