Strip computed properties in build-types transform#56450
Closed
rubennorte wants to merge 1 commit intofacebook:mainfrom
Closed
Strip computed properties in build-types transform#56450rubennorte wants to merge 1 commit intofacebook:mainfrom
rubennorte wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Changelog: [internal] Update the `stripPrivateProperties` Flow transform to also remove computed properties and methods from type definitions. These are implementation details that should not be part of the public API. Previously only underscore-prefixed identifiers were stripped. Now `PropertyDefinition` and `MethodDefinition` nodes with `node.computed === true` are also removed. Differential Revision: D100969511
meta-cla
bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100969511. |
Collaborator
|
This pull request was successfully merged by @rubennorte in fc331f3 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Update the
stripPrivatePropertiesFlow transform to also removecomputed properties and methods from type definitions. These are
implementation details that should not be part of the public API.
Previously only underscore-prefixed identifiers were stripped. Now
PropertyDefinitionandMethodDefinitionnodes withnode.computed === trueare also removed.Differential Revision: D100969511