Move CI validation for debugCpp and profileCpp to EnvironmentOptions#56464
Closed
rubennorte wants to merge 1 commit intofacebook:mainfrom
Closed
Move CI validation for debugCpp and profileCpp to EnvironmentOptions#56464rubennorte wants to merge 1 commit intofacebook:mainfrom
rubennorte wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Changelog: [internal] Moved the CI validation checks for `debugCpp` and `profileCpp` from the `run()` function in `tester.js` to `validateEnvironmentVariables()` in `EnvironmentOptions.js`, alongside the existing CI/OSS validation for memory instrumentation. This centralizes all environment option validation in one place, so invalid configurations are caught early during environment setup rather than at tester execution time. Differential Revision: D101159820
meta-cla
bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101159820. |
|
This pull request has been merged in def621f. |
Collaborator
|
This pull request was successfully merged by @rubennorte in def621f When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Moved the CI validation checks for
debugCppandprofileCppfrom therun()function intester.jstovalidateEnvironmentVariables()inEnvironmentOptions.js, alongside the existing CI/OSS validation for memory instrumentation.This centralizes all environment option validation in one place, so invalid configurations are caught early during environment setup rather than at tester execution time.
Differential Revision: D101159820