Skip to content

Align folder name for assets-registry package (#56891) #56891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huntie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Align folder name for assets-registry package (#56891) #56891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ module.exports = {
files: [
'./packages/react-native/Libraries/**/*.{js,flow}',
'./packages/react-native/src/**/*.{js,flow}',
'./packages/assets/registry.js',
'./packages/assets-registry/registry.js',
],
parser: 'hermes-eslint',
rules: {
Expand Down
2 changes: 1 addition & 1 deletion packages/assets/README.md → packages/assets-registry/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ yarn add --dev @react-native/assets-registry
To run the tests in this package, run the following commands from the React Native root folder:

1. `yarn` to install the dependencies. You just need to run this once
2. `yarn jest packages/assets`.
2. `yarn jest packages/assets-registry`.
0 ...ges/assets/__tests__/path-support-test.js → ...s-registry/__tests__/path-support-test.js
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions packages/assets/package.json → packages/assets-registry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
"repository": {
"type": "git",
"url": "git+https://github.com/facebook/react-native.git",
"directory": "packages/assets"
"directory": "packages/assets-registry"
},
"homepage": "https://github.com/facebook/react-native/tree/HEAD/packages/assets#readme",
"homepage": "https://github.com/facebook/react-native/tree/HEAD/packages/assets-registry#readme",
"keywords": [
"assets",
"registry",
Expand Down
0 packages/assets/path-support.js → packages/assets-registry/path-support.js
View file
Open in desktop
File renamed without changes.
0 packages/assets/registry.js → packages/assets-registry/registry.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/react-native/Libraries/Image/__tests__/resolveAssetSource-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* @format
*/

import type {PackagerAsset} from '../../../../assets/registry';
import type {PackagerAsset} from '../../../../assets-registry/registry';
import type {ResolvedAssetSource} from '../AssetSourceResolver';

describe('resolveAssetSource', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/metro.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const config = {
// Make Metro able to resolve required packages that might be imported from /packages/react-native
watchFolders: [
path.resolve(__dirname, '../../node_modules'),
path.resolve(__dirname, '../assets'),
path.resolve(__dirname, '../assets-registry'),
path.resolve(__dirname, '../normalize-color'),
path.resolve(__dirname, '../polyfills'),
path.resolve(__dirname, '../virtualized-lists'),
Expand Down
2 changes: 1 addition & 1 deletion packages/rn-tester/metro.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const config = {
// Make Metro able to resolve required external dependencies
watchFolders: [
path.resolve(__dirname, '../../node_modules'),
path.resolve(__dirname, '../assets'),
path.resolve(__dirname, '../assets-registry'),
path.resolve(__dirname, '../community-cli-plugin'),
path.resolve(__dirname, '../dev-middleware'),
path.resolve(__dirname, '../new-app-screen'),
Expand Down
2 changes: 1 addition & 1 deletion private/helloworld/metro.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const config = {
// Make Metro able to resolve required external dependencies
watchFolders: [
repositoryPath('node_modules'),
repositoryPath('packages/assets'),
repositoryPath('packages/assets-registry'),
repositoryPath('packages/normalize-color'),
repositoryPath('packages/polyfills'),
repositoryPath('packages/react-native'),
Expand Down
Loading