fix missing headers on image source in android#56905
Conversation
|
Hi @humaidk2! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Please add tests for this scenario so this doesn't regress in the future. |
|
This probably fixes an issue I had on Android with authenticated images that require Bearer tokens |
f8656bf to
31e9ce7
Compare
|
Thanks, added the tests. |
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D105848841. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
Simplify null check to satisfy flow conditions Co-authored-by: Peter Abbondanzo <peter@abbondanzo.com>
Simplify null check to satisfy flow conditions Co-authored-by: Peter Abbondanzo <peter@abbondanzo.com>
|
This pull request was successfully merged by @humaidk2 in eeb17ba When will my fix make it into a release? | How to file a pick request? |
Summary:
Discovered that Image headers are not passed to image component correctly for Android
Changelog:
Added headers to case where image props have headers in sources in Android Images
Pick one each for the category and type tags:
[ANDROID] [FIXED] - Source props in image headers in Android
Test Plan:
Added platform specific tests and validated headers were not ignored, removed them as don't want to create separate tests for this one specific case.