Skip to content

fix missing headers on image source in android#56905

Closed
humaidk2 wants to merge 5 commits into
facebook:mainfrom
humaidk2:fix-missing-image-headers
Closed

fix missing headers on image source in android#56905
humaidk2 wants to merge 5 commits into
facebook:mainfrom
humaidk2:fix-missing-image-headers

Conversation

@humaidk2
Copy link
Copy Markdown
Contributor

Summary:

Discovered that Image headers are not passed to image component correctly for Android

Changelog:

Added headers to case where image props have headers in sources in Android Images

Pick one each for the category and type tags:

[ANDROID] [FIXED] - Source props in image headers in Android

Test Plan:

Added platform specific tests and validated headers were not ignored, removed them as don't want to create separate tests for this one specific case.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 20, 2026

Hi @humaidk2!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 20, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label May 20, 2026
@javache
Copy link
Copy Markdown
Member

javache commented May 20, 2026

Please add tests for this scenario so this doesn't regress in the future.

@migueldaipre
Copy link
Copy Markdown
Collaborator

migueldaipre commented May 20, 2026

This probably fixes an issue I had on Android with authenticated images that require Bearer tokens

@humaidk2 humaidk2 force-pushed the fix-missing-image-headers branch from f8656bf to 31e9ce7 Compare May 20, 2026 15:18
@humaidk2
Copy link
Copy Markdown
Contributor Author

Thanks, added the tests.
They should be flagged in CI now if they break.

@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented May 20, 2026

@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D105848841.

@github-actions
Copy link
Copy Markdown

Warning

JavaScript API change detected

This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API.

  • Please include a clear changelog message.
  • This change will be subject to additional review.

This change was flagged as: POTENTIALLY_BREAKING

Comment thread packages/react-native/Libraries/Image/__tests__/Image-test.js Outdated
Comment thread packages/react-native/Libraries/Image/__tests__/Image-test.js Outdated
humaidk2 and others added 2 commits May 20, 2026 20:40
Simplify null check to satisfy flow conditions

Co-authored-by: Peter Abbondanzo <peter@abbondanzo.com>
Simplify null check to satisfy flow conditions

Co-authored-by: Peter Abbondanzo <peter@abbondanzo.com>
@meta-codesync meta-codesync Bot closed this in eeb17ba May 20, 2026
@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @humaidk2 in eeb17ba

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants