Promote event loop control JSI interface (#57005)#57005
Open
lavenzg wants to merge 1 commit into
Open
Conversation
|
@lavenzg has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106744174. |
This was referenced May 29, 2026
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
May 29, 2026
Summary: X-link: facebook/react-native#57005 Promote `IEventLoopControl` and `ISetEventLoopControl` out of `JSI_UNSTABLE` and make `HermesRuntimeImpl` always implement the setter interface. Keep unrelated unstable APIs such as serialization, tracing helpers, and Worker installation behind `JSI_UNSTABLE`. Differential Revision: D106744174
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
May 29, 2026
Summary: X-link: facebook/hermes#2037 Promote `IEventLoopControl` and `ISetEventLoopControl` out of `JSI_UNSTABLE` and make `HermesRuntimeImpl` always implement the setter interface. Keep unrelated unstable APIs such as serialization, tracing helpers, and Worker installation behind `JSI_UNSTABLE`. Changelog: [Internal] Differential Revision: D106744174
f4a9785 to
83e6abb
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
May 29, 2026
Summary: X-link: facebook/react-native#57005 Promote `IEventLoopControl` and `ISetEventLoopControl` out of `JSI_UNSTABLE` and make `HermesRuntimeImpl` always implement the setter interface. Keep unrelated unstable APIs such as serialization, tracing helpers, and Worker installation behind `JSI_UNSTABLE`. Changelog: [Internal] Differential Revision: D106744174
Summary: X-link: facebook/hermes#2037 Promote `IEventLoopControl` and `ISetEventLoopControl` out of `JSI_UNSTABLE` and make `HermesRuntimeImpl` always implement the setter interface. Keep unrelated unstable APIs such as serialization, tracing helpers, and Worker installation behind `JSI_UNSTABLE`. Other hermes branches do not implement `ISetEventLoopControl`, for now. Changelog: [Internal] Differential Revision: D106744174
83e6abb to
e91e295
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
May 29, 2026
Summary: X-link: facebook/react-native#57005 Promote `IEventLoopControl` and `ISetEventLoopControl` out of `JSI_UNSTABLE` and make `HermesRuntimeImpl` always implement the setter interface. Keep unrelated unstable APIs such as serialization, tracing helpers, and Worker installation behind `JSI_UNSTABLE`. Other hermes branches do not implement `ISetEventLoopControl`, for now. Changelog: [Internal] Differential Revision: D106744174
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/hermes#2037
Promote
IEventLoopControlandISetEventLoopControlout ofJSI_UNSTABLEand makeHermesRuntimeImplalways implement the setter interface. Keep unrelated unstable APIs such as serialization, tracing helpers, and Worker installation behindJSI_UNSTABLE.Other hermes branches do not implement
ISetEventLoopControl, for now.Changelog: [Internal]
Differential Revision: D106744174