Skip to content

Deprecate NativeMethods interface (#57031)#57031

Closed
huntie wants to merge 3 commits into
facebook:mainfrom
huntie:export-D107129358
Closed

Deprecate NativeMethods interface (#57031)#57031
huntie wants to merge 3 commits into
facebook:mainfrom
huntie:export-D107129358

Conversation

@huntie
Copy link
Copy Markdown
Member

@huntie huntie commented Jun 1, 2026

Summary:

Also update the already deprecated NativeMethodsMixin and NativeMethodsMixinType types to point to HostInstance as canonical.

Changelog:
[General][Deprecated] - The NativeMethods interface is deprecated. Use HostInstance instead.

Reviewed By: rubennorte

Differential Revision: D107129358

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 1, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Jun 1, 2026

@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107129358.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

Warning

JavaScript API change detected

This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API.

  • Please include a clear changelog message.
  • This change will be subject to additional review.

This change was flagged as: POTENTIALLY_BREAKING

@meta-codesync meta-codesync Bot changed the title Deprecate NativeMethods interface Deprecate NativeMethods interface (#57031) Jun 2, 2026
@huntie huntie force-pushed the export-D107129358 branch from b4ff2ea to 23e9390 Compare June 2, 2026 11:24
huntie added a commit to huntie/react-native that referenced this pull request Jun 2, 2026
Summary:

Also update the already deprecated `NativeMethodsMixin` and `NativeMethodsMixinType` types to point to `HostInstance` as canonical.

Changelog:
[General][Deprecated] - The `NativeMethods` interface is deprecated. Use `HostInstance` instead.

Differential Revision: D107129358
huntie added a commit to huntie/react-native that referenced this pull request Jun 2, 2026
Summary:

Also update the already deprecated `NativeMethodsMixin` and `NativeMethodsMixinType` types to point to `HostInstance` as canonical.

Changelog:
[General][Deprecated] - The `NativeMethods` interface is deprecated. Use `HostInstance` instead.

Differential Revision: D107129358
huntie added a commit to huntie/react-native that referenced this pull request Jun 2, 2026
Summary:

Also update the already deprecated `NativeMethodsMixin` and `NativeMethodsMixinType` types to point to `HostInstance` as canonical.

Changelog:
[General][Deprecated] - The `NativeMethods` interface is deprecated. Use `HostInstance` instead.

Reviewed By: rubennorte

Differential Revision: D107129358
@huntie huntie force-pushed the export-D107129358 branch from 23e9390 to fac6cdc Compare June 2, 2026 13:55
huntie added a commit to huntie/react-native that referenced this pull request Jun 2, 2026
Summary:

Also update the already deprecated `NativeMethodsMixin` and `NativeMethodsMixinType` types to point to `HostInstance` as canonical.

Changelog:
[General][Deprecated] - The `NativeMethods` interface is deprecated. Use `HostInstance` instead.

Reviewed By: rubennorte

Differential Revision: D107129358
huntie added 3 commits June 2, 2026 09:34
Summary:

Add `pointerEvents` to `TextProps` in the Flow source. This prop is supported at the native layer — `BaseParagraphProps` (the C++ props struct for Text/Paragraph) extends `ViewProps`, which includes `pointerEvents`. The old hand-written TypeScript types (`Text.d.ts`) already declared this prop, but the Flow source did not, causing a gap in the auto-generated strict API types (`types_generated`).

Changelog:
[General][Fixed] - **Strict TypeScript API**: Add missing `pointerEvents` prop to `Text` component

Reviewed By: cortinico

Differential Revision: D106183960
Summary:

**Motivation**

`NativeDialogManagerAndroid` is an internal native module used by `Alert` and `PermissionsAndroid` on Android, not an intended root React Native public API.

**Notes**

- `NativeDialogManagerAndroid` wasn't defined on our manual public TypeScript types — so was never discoverable via TypeScript auto-import.
- Appears unused by open source consumers with public code on GitHub ([search](https://github.com/search?type=code&q=NativeDialogManagerAndroid++NOT+is%3Aarchived+NOT+is%3Afork+language%3ATypeScript&l=TypeScript⁄)).

Changelog:
[General][Breaking] - The `NativeDialogManagerAndroid` export is removed.

Reviewed By: cortinico

Differential Revision: D107250968
Summary:

Also update the already deprecated `NativeMethodsMixin` and `NativeMethodsMixinType` types to point to `HostInstance` as canonical.

Changelog:
[General][Deprecated] - The `NativeMethods` interface is deprecated. Use `HostInstance` instead.

Reviewed By: rubennorte

Differential Revision: D107129358
@huntie huntie force-pushed the export-D107129358 branch from fac6cdc to f73715a Compare June 2, 2026 16:35
huntie added a commit to huntie/react-native that referenced this pull request Jun 2, 2026
Summary:

Also update the already deprecated `NativeMethodsMixin` and `NativeMethodsMixinType` types to point to `HostInstance` as canonical.

Changelog:
[General][Deprecated] - The `NativeMethods` interface is deprecated. Use `HostInstance` instead.

Reviewed By: rubennorte

Differential Revision: D107129358
@meta-codesync meta-codesync Bot closed this in 19f5691 Jun 2, 2026
@facebook-github-tools facebook-github-tools Bot added the Merged This PR has been merged. label Jun 2, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Jun 2, 2026

This pull request has been merged in 19f5691.

@huntie huntie deleted the export-D107129358 branch June 2, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant