Convert ReactHorizontalScrollView to Kotlin#57045
Open
cortinico wants to merge 2 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107236883. |
cortinico
force-pushed
the
export-D107236883
branch
2 times, most recently
from
31b4633 to
7e60edf
Compare
Summary: Convert `ReactScrollView.java` to `ReactScrollView.kt` and update the `generate-nested-scroll-view.js` script to generate `ReactNestedScrollView.kt` from the Kotlin source. Key changes: - `ReactScrollView.java` replaced by idiomatic `ReactScrollView.kt` - `ReactNestedScrollView.java` replaced by generated `ReactNestedScrollView.kt` - Generation script updated for Kotlin source/output file paths and transformations - BUCK file updated to reference `.kt` files in the verification genrule - `ReactScrollViewManager.kt` updated to use Kotlin property access syntax for `scrollEnabled`, `stateWrapper`, and `fadingEdgeLengthStart/End` - Public API surface preserved: only additive `synthetic` constructor from `JvmOverloads` Changelog: [Android][Changed] - Convert `ReactScrollView` and `ReactNestedScrollView` from Java to Kotlin Differential Revision: D107236882
Summary: Convert `ReactHorizontalScrollView.java` to `ReactHorizontalScrollView.kt` using idiomatic Kotlin while preserving the public API surface. Key changes: - `ReactHorizontalScrollView.java` replaced by `ReactHorizontalScrollView.kt` - `ReactHorizontalScrollViewManager.kt` updated to use Kotlin property access syntax for `scrollEnabled`, `stateWrapper`, and `fadingEdgeLengthStart/End` - Static helper methods (`findDeepestScrollViewForMotionEvent`) moved into the companion object - Public API surface preserved: only additive `synthetic` constructor from `JvmOverloads` Changelog: [Android][Changed] - Convert `ReactHorizontalScrollView` from Java to Kotlin Differential Revision: D107236883
cortinico
force-pushed
the
export-D107236883
branch
from
7e60edf to
d7ab07d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Convert
ReactHorizontalScrollView.javatoReactHorizontalScrollView.ktusing idiomatic Kotlin while preserving the public API surface.Key changes:
ReactHorizontalScrollView.javareplaced byReactHorizontalScrollView.ktReactHorizontalScrollViewManager.ktupdated to use Kotlin property access syntax forscrollEnabled,stateWrapper, andfadingEdgeLengthStart/EndfindDeepestScrollViewForMotionEvent) moved into the companion objectsyntheticconstructor fromJvmOverloadsChangelog:
[Android][Changed] - Convert
ReactHorizontalScrollViewfrom Java to KotlinDifferential Revision: D107236883