[DevTools] fix: dedupe file fetch requests and define a timeout#34566
Merged
hoxyq merged 1 commit intofacebook:mainfrom Sep 23, 2025
Merged
[DevTools] fix: dedupe file fetch requests and define a timeout#34566hoxyq merged 1 commit intofacebook:mainfrom
hoxyq merged 1 commit intofacebook:mainfrom
Conversation
hoxyq
changed the title
eps1lon
approved these changes
Sep 23, 2025
Collaborator
eps1lon
left a comment
eps1lon
left a comment
There was a problem hiding this comment.
Not too stoked about the timeout but we'll see if that's too disruptive.
Contributor
Author
We need at least something to guarantee that pending requests will be cleared out, so we won't end up in a state with incorrect cache. 1 minute seemed reasonable to me, but we could bump it, if needed. |
EugeneChoi4
pushed a commit
to EugeneChoi4/react
that referenced
this pull request
Sep 24, 2025
…book#34566) If there is a large owner stack, we could potentially spam multiple fetch requests for the same source map. This adds a simple deduplication logic, based on URL. Also, this adds a timeout of 60 seconds to all fetch requests initiated by fileFetcher content script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a large owner stack, we could potentially spam multiple fetch requests for the same source map. This adds a simple deduplication logic, based on URL.
Also, this adds a timeout of 60 seconds to all fetch requests initiated by fileFetcher content script.