[DevTools] fix: dont ship source maps for css in prod builds#34886
Closed
hoxyq wants to merge 1 commit intofacebook:mainfrom
Closed
[DevTools] fix: dont ship source maps for css in prod builds#34886hoxyq wants to merge 1 commit intofacebook:mainfrom
hoxyq wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
Author
|
Surprisingly, this actually breaks the load of CSS, trying to understand why. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been causing some issues with the submission review on Firefox store: we use OS-level paths in these source maps, which makes the build artifact different from the one that's been submitted.
Also saves ~100Kb for
main.jsartifact.