Fix: change private field from string to boolean in react-devtools-fusebox#36290
Open
Jah-yee wants to merge 1 commit intofacebook:mainfrom
Open
Fix: change private field from string to boolean in react-devtools-fusebox#36290Jah-yee wants to merge 1 commit intofacebook:mainfrom
Jah-yee wants to merge 1 commit intofacebook:mainfrom
Conversation
…sebox The private field in package.json should be a boolean per npm specification, not a string. This fixes validation errors in package scanning tools. Fixes facebook#35793
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day
Summary
Changed the
privatefield inpackages/react-devtools-fusebox/package.jsonfrom string"true"to booleantrue, fixing a malformed package.json that violates npm specification.Changes
packages/react-devtools-fusebox/package.json"private": "true"→"private": trueWhy this fix is correct
Per the npm package.json specification, the
privatefield must be a boolean. The string value caused validation failures in package scanning tools like ScanCode.io.This follows the fix in aboutcode-org/scancode-toolkit#4635 which added downstream workarounds — the source data should comply with the specification.
Testing
Fixes #35793.
Thank you for your attention. If there are any issues or suggestions, please leave a comment and I will address them promptly.
Warmly,
RoomWithOutRoof