Transform fbcode/eden

Summary:
This diff changes the struct initialization method from using positional arguments to keyword arguments, as indicated in the file title.

Background:

In thrift-python, user must use keyword arguments to initialize both mutable and immutable objects, meaning positional arguments are not allowed for this purpose. This behavior differs from py-deprecated, which permits both keyword and positional arguments for object initialization. To facilitate the migration from py-deprecated, we developed a tool that identifies all instances of struct initialization using positional arguments and converts them to keyword arguments. This will reduce the workload for users during the migration, and this diff is one of the outputs by using the tool.

Reviewed By: dtolnay

Differential Revision: D75805486

fbshipit-source-id: d99d6677c79ed3205c8741e1b401e80556a6d6d8

Author: Sunnie912

eden/fs/cli/debug.py

@@ -270,9 +270,9 @@ def run(self, args: argparse.Namespace) -> int:
         with instance.get_thrift_client_legacy() as client:
             resp = client.debugGetTree(
                 DebugGetScmTreeRequest(
-                    MountId(bytes(checkout.path)),
-                    tree_id,
-                    origin_flags,
+                    mountId=MountId(mountPoint=bytes(checkout.path)),
+                    id=tree_id,
+                    origins=origin_flags,
                 )
             )
             if args.all:
@@ -566,9 +566,9 @@ def run(self, args: argparse.Namespace) -> int:
         with instance.get_thrift_client_legacy() as client:
             data = client.debugGetBlob(
                 DebugGetScmBlobRequest(
-                    MountId(bytes(checkout.path)),
-                    blob_id,
-                    origin_flags,
+                    mountId=MountId(mountPoint=bytes(checkout.path)),
+                    id=blob_id,
+                    origins=origin_flags,
                 )
             )
             if args.all:
@@ -617,9 +617,9 @@ def run(self, args: argparse.Namespace) -> int:
         with instance.get_thrift_client_legacy() as client:
             info = client.debugGetBlobMetadata(
                 DebugGetBlobMetadataRequest(
-                    MountId(bytes(checkout.path)),
-                    blob_id,
-                    origin_flags,
+                    mountId=MountId(mountPoint=bytes(checkout.path)),
+                    id=blob_id,
+                    origins=origin_flags,
                 )
             )
 
@@ -646,7 +646,7 @@ def check_blob_and_size_match(
     try:
         response = client.debugGetBlob(
             DebugGetScmBlobRequest(
-                mountId=MountId(bytes(checkout)),
+                mountId=MountId(mountPoint=bytes(checkout)),
                 id=identifying_hash,
                 origins=DataFetchOrigin.LOCAL_BACKING_STORE,  # We don't want to cause any network fetches.
             )
@@ -664,9 +664,9 @@ def check_blob_and_size_match(
             blobmeta = (
                 client.debugGetBlobMetadata(
                     DebugGetBlobMetadataRequest(
-                        MountId(bytes(checkout)),
-                        identifying_hash,
-                        DataFetchOrigin.DISK_CACHE,
+                        mountId=MountId(mountPoint=bytes(checkout)),
+                        id=identifying_hash,
+                        origins=DataFetchOrigin.DISK_CACHE,
                     )
                 )
                 .metadatas[0]

eden/fs/cli/top.py

@@ -1044,7 +1044,15 @@ def __init__(self, pid: int, cmd: bytes, mount: bytes) -> None:
         self.pid = pid
         self.cmd = format_cmd(cmd)
         self.mount = format_mount(mount)
-        self.access_counts = AccessCounts(0, 0, 0, 0, 0, 0, 0)
+        self.access_counts = AccessCounts(
+            fsChannelTotal=0,
+            fsChannelReads=0,
+            fsChannelWrites=0,
+            fsChannelBackingStoreImports=0,
+            fsChannelDurationNs=0,
+            fsChannelMemoryCacheImports=0,
+            fsChannelDiskCacheImports=0,
+        )
         self.fuseFetch = 0
         self.last_access = time.monotonic()
         self.is_running = True

eden/integration/hg/filteredhg_clone_test.py

@@ -148,7 +148,9 @@ def test_eden_get_filter_empty(self) -> None:
 
         with self.get_thrift_client_legacy() as client:
             result = client.getCurrentSnapshotInfo(
-                GetCurrentSnapshotInfoRequest(MountId(os.fsencode(path)))
+                GetCurrentSnapshotInfoRequest(
+                    mountId=MountId(mountPoint=os.fsencode(path))
+                )
             )
             self.assertEqual("null", result.filterId)
 
@@ -159,7 +161,9 @@ def test_eden_get_filter(self) -> None:
 
         with self.get_thrift_client_legacy() as client:
             result = client.getCurrentSnapshotInfo(
-                GetCurrentSnapshotInfoRequest(MountId(os.fsencode(path)))
+                GetCurrentSnapshotInfoRequest(
+                    mountId=MountId(mountPoint=os.fsencode(path))
+                )
             )
             self.assertNotEqual(None, result.filterId)
             if result.filterId is not None:
@@ -192,6 +196,8 @@ def test_eden_get_filter_nonfiltered(self) -> None:
 
         with self.get_thrift_client_legacy() as client:
             result = client.getCurrentSnapshotInfo(
-                GetCurrentSnapshotInfoRequest(MountId(os.fsencode(path)))
+                GetCurrentSnapshotInfoRequest(
+                    mountId=MountId(mountPoint=os.fsencode(path))
+                )
             )
             self.assertEqual(None, result.filterId)

eden/integration/lib/eden_server_inspector.py

@@ -34,7 +34,9 @@ def unload_inode_for_path(self, path: str = "") -> None:
         """path: relative path to a directory under the mount."""
         with self.create_thrift_client() as client:
             client.unloadInodeForPath(
-                os.fsencode(self._mount_point), os.fsencode(path), age=TimeSpec(0, 0)
+                os.fsencode(self._mount_point),
+                os.fsencode(path),
+                age=TimeSpec(seconds=0, nanoSeconds=0),
             )
 
     def get_inode_count(self, path: str = "") -> int:

eden/integration/lib/prjfs_test.py

@@ -98,7 +98,7 @@ def getAllMaterialized(self, waitTime: int = 5) -> Set[Tuple[Path, int]]:
                 self.mount_path_bytes,
                 b"",
                 DIS_REQUIRE_MATERIALIZED,
-                SyncBehavior(waitTime),
+                SyncBehavior(syncTimeoutSeconds=waitTime),
             )
 
         for tree_inode in inodes:

eden/integration/lib/thrift_objects.py

@@ -51,12 +51,16 @@ def buildSmallChange(
     if changeType == SmallChangeNotification.ADDED:
         assert path
         return ChangeNotification(
-            SmallChangeNotification(added=Added(fileType=fileType, path=path))
+            smallChange=SmallChangeNotification(
+                added=Added(fileType=fileType, path=path)
+            )
         )
     elif changeType == SmallChangeNotification.MODIFIED:
         assert path
         return ChangeNotification(
-            SmallChangeNotification(modified=Modified(fileType=fileType, path=path))
+            smallChange=SmallChangeNotification(
+                modified=Modified(fileType=fileType, path=path)
+            )
         )
     elif changeType == SmallChangeNotification.RENAMED:
         assert from_path
@@ -86,7 +90,9 @@ def buildSmallChange(
     elif changeType == SmallChangeNotification.REMOVED:
         assert path
         return ChangeNotification(
-            SmallChangeNotification(removed=Removed(fileType=fileType, path=path))
+            smallChange=SmallChangeNotification(
+                removed=Removed(fileType=fileType, path=path)
+            )
         )
     return ChangeNotification()