Skip to content

Commit 5a4d15b

Browse files
ajaymenonmeta-codesync[bot]
authored andcommitted
Fix reviewstack.dev deploy by removing broken Docker container dependency take 2 (#1216)
Summary: The repo used to have a CI workflow that built an Ubuntu 22.04 Docker image (generated by `ci/gen_workflows.py` as `sapling-cli-ubuntu-22.04-image.yml`) and pushed it to GitHub Container Registry as `ghcr.io/facebook/sapling/build_ubuntu_22_04:latest`. At some point, that workflow and its Dockerfile were removed from the repo, but two workflows that depend on that image were never updated: - `reviewstack.dev-deploy.yml` - `sapling-addons.yml` So every time either of those workflows runs, it tries to pull an image that no longer exists, and fails immediately at container initialization. Example failure on `main`: https://github.com/facebook/sapling/actions/runs/21693937235/job/62559938248 Pull Request resolved: #1216 Test Plan: Not 100% sure how to test this tbh. I tried to add a trigger to get GHA to pick up the change and see if the deploy action would succeed but it looks like I don't have permissions to do that. ubuntu-22.04 should already have node and yarn so the build deployment should work without any custom dependencies. Redo of #1208 Reviewed By: bherila Differential Revision: D92742046 fbshipit-source-id: 4fda096b331b775619491c6b16a162f83da0d380
1 parent 0c89fa3 commit 5a4d15b

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

.github/workflows/reviewstack.dev-deploy.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,22 @@ on:
88
jobs:
99
deploy:
1010
runs-on: ubuntu-22.04
11-
# Our build container already has Node, Yarn, and Python installed.
12-
container:
13-
image: ${{ format('ghcr.io/{0}/build_ubuntu_22_04:latest', github.repository) }}
1411
concurrency:
1512
group: ${{ github.workflow }}-${{ github.ref }}
1613
steps:
1714
- name: Checkout Code
1815
uses: actions/checkout@v6
16+
- name: Setup Node.js
17+
uses: actions/setup-node@v4
18+
with:
19+
node-version: '18'
20+
- name: Install Yarn
21+
run: npm install -g yarn
1922
- name: Grant Access
2023
run: git config --global --add safe.directory "$PWD"
2124
- name: Install dependencies
2225
working-directory: ./eden/contrib/
23-
run: yarn install --prefer-offline
26+
run: yarn install
2427

2528
# Build codegen and then do some sanity checks so we don't push the site
2629
# when the tests are broken.

0 commit comments

Comments
 (0)