Commit 5a4d15b
Fix reviewstack.dev deploy by removing broken Docker container dependency take 2 (#1216)
Summary:
The repo used to have a CI workflow that built an Ubuntu 22.04 Docker image (generated by `ci/gen_workflows.py` as `sapling-cli-ubuntu-22.04-image.yml`) and pushed it to GitHub Container Registry as `ghcr.io/facebook/sapling/build_ubuntu_22_04:latest`. At some point, that workflow and its Dockerfile were removed from the repo, but two workflows that depend on that image were never updated:
- `reviewstack.dev-deploy.yml`
- `sapling-addons.yml`
So every time either of those workflows runs, it tries to pull an image that no longer exists, and fails immediately at container initialization.
Example failure on `main`: https://github.com/facebook/sapling/actions/runs/21693937235/job/62559938248
Pull Request resolved: #1216
Test Plan:
Not 100% sure how to test this tbh. I tried to add a trigger to get GHA to pick up the change and see if the deploy action would succeed but it looks like I don't have permissions to do that.
ubuntu-22.04 should already have node and yarn so the build deployment should work without any custom dependencies.
Redo of #1208
Reviewed By: bherila
Differential Revision: D92742046
fbshipit-source-id: 4fda096b331b775619491c6b16a162f83da0d3801 parent 0c89fa3 commit 5a4d15b
1 file changed
Lines changed: 7 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | 11 | | |
15 | 12 | | |
16 | 13 | | |
17 | 14 | | |
18 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
19 | 22 | | |
20 | 23 | | |
21 | 24 | | |
22 | 25 | | |
23 | | - | |
| 26 | + | |
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
| |||
0 commit comments