Add new annotation scope for function parameters, warn on field annotations for function parameters

Summary:
- Add a new annotation scope for RPC function parameters
- Emit a warning when using field-scoped annotations (without a function parameter scope)
- Add function parameter scope to common annotations where applicable

Reviewed By: vitaut, iahs

Differential Revision: D75463963

fbshipit-source-id: 3f0d05ce3046dad8cf2646ee064b0f002586e7e7

Author: hchokshi

thrift/annotation/cpp.thrift

@@ -57,6 +57,7 @@ struct Name {
  */
 @scope.Typedef
 @scope.Field
+@scope.FunctionParameter
 struct Type {
   1: string name;
 

thrift/annotation/go.thrift

@@ -28,13 +28,15 @@ namespace py thrift.annotation.go
 // Annotation for overriding Go names (e.g. to avoid codegen name conflicts).
 @scope.Field
 @scope.Function
+@scope.FunctionParameter
 @scope.Typedef
 struct Name {
   1: string name;
 }
 
 // Annotation for overriding Go struct field tags (e.g. json, yaml, serf tags).
 @scope.Field
+@scope.FunctionParameter
 struct Tag {
   1: string tag;
 }

thrift/annotation/java.thrift

@@ -33,6 +33,7 @@ struct Mutable {}
 
 // When this annotation is applied, thrift compiler will annotate corresponding java entity the given java annotation.
 @scope.Field
+@scope.FunctionParameter
 @scope.Struct
 @scope.Union
 @scope.Exception

thrift/annotation/python.thrift

@@ -27,7 +27,12 @@ namespace py thrift.annotation.python
 // start
 
 /// Hides in thrift-py3 only, not in thrift-python
-@scope.Definition
+/// Allowed for all @scope.Definition, except for @scope.FunctionParameter as that would hide part of
+/// the RPC function parameters.
+@scope.RootDefinition
+@scope.Field
+@scope.Function
+@scope.Transitive
 struct Py3Hidden {}
 
 /// Hides in thrift-py-deprecated only

thrift/annotation/rust.thrift

@@ -262,6 +262,7 @@ struct NewType {}
  * | `&'a T<K, V>`  | `IntoIterator<Item = (&'a K, &'a V)>`
  */
 @scope.Field
+@scope.FunctionParameter
 @scope.Typedef
 struct Type {
   1: string name;

thrift/annotation/scope.thrift

@@ -86,7 +86,7 @@ struct Union {}
 /** The `exception` definition scope. */
 struct Exception {}
 
-/** Field declartaions, for example in `struct` or `function` declartions. */
+/** Field declarations, for example in `struct` declaration. */
 struct Field {}
 
 /** The `typedef` definition scope. */
@@ -102,6 +102,9 @@ struct Interaction {}
 struct Function {}
 /* added by compiler: (hack.name = "TFunction", js.name = "TFunction") */
 
+/** The `function parameter` definition scope. */
+struct FunctionParameter {}
+
 /** The Enum value definition scope. */
 struct EnumValue {}
 
@@ -141,6 +144,7 @@ struct RootDefinition {}
 @RootDefinition
 @Field
 @Function
+@FunctionParameter
 @EnumValue
 @Transitive
 struct Definition {}