Commit a79e5ae
Update servers/slapi, tests, and tools crates (final batch) to use new mononoke justknob crate
Summary:
Mechanical step 10/10 of the BUCK dep swap from `//common/rust/shed/justknobs_stub:justknobs` to `//eden/mononoke/common/rust/justknobs_ext:justknobs`. See D106467432 for the motivation and the new crate.
After this diff, no crate under `fbcode/eden/mononoke/` depends on `//common/rust/shed/justknobs_stub:justknobs` directly. Every Mononoke caller now goes through `//eden/mononoke/common/rust/justknobs_ext:justknobs`, which enforces the Mononoke style rule that a missing or misspelled JustKnob panics at the call site instead of being silently masked by `unwrap_or(default)`.
**I confirmed that no other crates under `eden/mononoke` (besides the new `justknobs_ext`) depend directly on the `justknobs_stub` crate :
```
╰─>$ buck2 cquery 'kind("rust*", rdeps(fbcode//eden/mononoke/..., fbcode//common/rust/shed/justknobs_stub:, 1))' > /tmp/justknobs_stub_deps_mononoke.out
Skipped 101 incompatible targets:
fbcode//eden/mononoke/clients/facebook/git_pushrebase:_git_universal_pushrebase_macos_arm64 (cfg:dev-linux-x86_64-fbcode-platform010-clang19-asan-ubsan-dev#5f46caaa1d33a3cc)
fbcode//eden/mononoke/clients/facebook/git_pushrebase:_git_universal_pushrebase_macos_x86_64 (cfg:dev-linux-x86_64-fbcode-platform010-clang19-asan-ubsan-dev#5f46caaa1d33a3cc)
fbcode//eden/mononoke/clients/facebook/git_pushrebase:git_universal_pushrebase (cfg:dev-linux-x86_64-fbcode-platform010-clang19-asan-ubsan-dev#5f46caaa1d33a3cc)
...
fbcode//eden/mononoke/scs/if:source_control-py3-default-types__source_control/types.cpp (cfg:dev-linux-x86_64-fbcode-platform010-clang19-asan-ubsan-dev#d7f75479a3c4990a)
fbcode//eden/mononoke/scs/if:source_control-py3-default-types__source_control/types_empty.cpp (cfg:dev-linux-x86_64-fbcode-platform010-clang19-asan-ubsan-dev#d7f75479a3c4990a)
fbcode//eden/mononoke/scs/if:source_control-py3-default-types__source_control/types_fields.cpp (cfg:dev-linux-x86_64-fbcode-platform010-clang19-asan-ubsan-dev#d7f75479a3c4990a)
Buck UI: https://www.internalfb.com/buck2/1dc29406-336b-4608-a280-b6927dd85b18
Network: Up: 0B Down: 0B
Command: cquery.
Time elapsed: 8.4s
[2026-05-27T11:41:08.160+01:00] Network: Up: 0B Down: 0B
┬─[gustavoavena@devvm34754:/d/r/f/fbcode]─[10:41:08] (954d0c1b1b)
╰─>$ cat /tmp/justknobs_stub_deps_mononoke.out | cut -d' ' -f1 | sort | uniq
fbcode//common/rust/shed/justknobs_stub:justknobs
fbcode//datainfra/privacy/policy_zones_metadata/fetch_policy_zones_label:fetch_policy_zones_label
fbcode//eden/mononoke/common/rust/justknobs_ext:justknobs
fbcode//eden/mononoke/common/rust/justknobs_ext:justknobs-unittest
```
Reviewed By: YousefSalama
Differential Revision: D106489346
fbshipit-source-id: d60926cfc9c12f0ed68fe8817ef1be862abc300a1 parent 93ded00 commit a79e5ae
9 files changed
Lines changed: 9 additions & 9 deletions
File tree
- eden/mononoke
- tests/utils
- src
- tools/admin
- src/commands
- megarepo
- redaction
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | 26 | | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
| 162 | + | |
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
65 | 64 | | |
66 | 65 | | |
67 | 66 | | |
| |||
79 | 78 | | |
80 | 79 | | |
81 | 80 | | |
| 81 | + | |
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
207 | 207 | | |
208 | 208 | | |
209 | 209 | | |
210 | | - | |
| 210 | + | |
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
187 | | - | |
| 187 | + | |
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
| 59 | + | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| |||
0 commit comments