Skip to content

Commit a8439cc

Browse files
lmvasquezgmeta-codesync[bot]
authored andcommitted
Default local test scripts to opt mode
Summary: Mononoke's own docs recommend running integration tests in mode/opt because they're much faster. These helper scripts defaulted to mode/dev, which meant engineers running tests locally without specifying a mode got slow dev builds with little cache hit sicne we don't run ci on dev. Aligning the defaults with the documented recommendation. Reviewed By: YousefSalama Differential Revision: D104249602 fbshipit-source-id: 0a12be56af0697aa9dd66ab8deb622c97dd281c3
1 parent 933d1f9 commit a8439cc

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

eden/mononoke/tests/integration/incremental_integration_setup.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ fi
2727

2828
shift
2929

30-
# Set the default build mode to 'mode/dev', which is the same mode used in CI.
31-
build_args=("@fbcode//mode/dev")
30+
# Set the default build mode to 'mode/opt', which is the same mode used in CI.
31+
build_args=("@fbcode//mode/opt")
3232
if [ $# -ne 0 ]; then
3333
build_args=("$@")
3434
fi

eden/mononoke/tests/integration/run-test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if [ $# -eq 0 ]; then
2727
print_help
2828
fi
2929

30-
mode="fbcode//mode/dev"
30+
mode="fbcode//mode/opt"
3131

3232
while [[ $# -gt 0 ]]; do
3333
arg="$1"

0 commit comments

Comments
 (0)