Skip to content

Commit bb1eedc

Browse files
richardsonnickterrelln
authored andcommitted
correct mmap error check
Update mmap error validation to check for MAP_FAILED instead of NULL. POSIX specifies that mmap returns MAP_FAILED (-1) on failure.
1 parent 2107c8f commit bb1eedc

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

programs/fileio.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1050,7 +1050,9 @@ static size_t FIO_setDictBufferMMap(FIO_Dict_t* dict, const char* fileName, FIO_
10501050
}
10511051

10521052
*bufferPtr = mmap(NULL, (size_t)fileSize, PROT_READ, MAP_PRIVATE, fileHandle, 0);
1053-
if (*bufferPtr==NULL) EXM_THROW(34, "%s", strerror(errno));
1053+
if (*bufferPtr == MAP_FAILED) {
1054+
EXM_THROW(34, "%s", strerror(errno))
1055+
}
10541056

10551057
close(fileHandle);
10561058
return (size_t)fileSize;

0 commit comments

Comments
 (0)