Release resources before returning#4401
Merged
Merged
Conversation
In main, resources were freed on the success path but not in the error path. This change ensures all allocated resources are released before returning.
Cyan4973
approved these changes
Jun 4, 2025
Contributor
There was a problem hiding this comment.
I understand that it's considered "proper" to clean all resources on exiting the function.
To be fair, since it's main(), it's leaving program execution immediately on return(). Hence all resources are going to be released anyway. So the benefit seems moot.
That being said, the complexity introduced is also quite low, so it's a reasonable trade off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In main, resources were freed on the success path but not in the error path. This change ensures all allocated resources are released before returning.