Skip to content

Remove need for trailing forward slash in dir#4459

Merged
Cyan4973 merged 1 commit into
facebook:devfrom
Margen67:premake
Aug 17, 2025
Merged

Remove need for trailing forward slash in dir#4459
Cyan4973 merged 1 commit into
facebook:devfrom
Margen67:premake

Conversation

@Margen67

Copy link
Copy Markdown
Contributor

If a trailing forward slash wasn't present you would get cryptic build errors.

Alternatively, it should be documented that a slash at the end is necessary:

-- dir needs a slash at the end

@meta-cla

meta-cla Bot commented Aug 17, 2025

Copy link
Copy Markdown

Hi @Margen67!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Aug 17, 2025
@meta-cla

meta-cla Bot commented Aug 17, 2025

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Cyan4973 Cyan4973 self-assigned this Aug 17, 2025
@Cyan4973
Cyan4973 merged commit 3991e8a into facebook:dev Aug 17, 2025
102 checks passed
@Margen67
Margen67 deleted the premake branch August 18, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants