This repository was archived by the owner on Mar 3, 2020. It is now read-only.
Base improvements#635
Open
JasonTarka wants to merge 4 commits into
Open
Conversation
- Handle http/https/ftp/etc. prefix for base URLs - Previously `http://example.com` would lead to the system calling `http:12345`; now will call example.com:12345 - Better display of non-http(s) links - If there's a port listed, show the full `nc 1.2.3.4 567`, if not, show just `1.2.3.4` (previously would show `nc 1.2.3.4 undefined) - Readonly, rather than disabled, so the text can be scrolled & selected
It makes more logical sense to have the capture score be the main capture points, and the holding score be the bonus points, rather than the previous capture = bonus, hold = points. - Adding version detection to allow old exports to be imported easily. - Extra logging to make debugging easier/possible - This will make upcoming changes to the base display easier.
- Mark as 'held' rather than 'captured' when the controlling team hasn't changed - Don't spam the gameboard's activity log with messages of a team holding a base - Show in the activity log when a base is captured by another team
- Show points for both capturing & holding a base - Show non-http(s) links as full-width, so they're easier to read - Show "Capture Points" & "Keep points" when editing bases instead of "Points" & "Bonus"
Contributor
Author
|
Note: This relies on |
|
Please throw us a bone.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve appearance of bases & links
Mark bases as "held" when the team doesn't change
Reverse points/bonus for bases
Functional fixes for bases & links
http://example.comwould lead to the system callinghttp:12345; will now call example.com:12345nc 1.2.3.4 567, if not, show just1.2.3.4(previously would show `nc 1.2.3.4 undefined)