Add fp16 support for sample_farthest_points, ball_query and knn#1929
Open
eamonn-zh wants to merge 10 commits into
Open
Add fp16 support for sample_farthest_points, ball_query and knn#1929eamonn-zh wants to merge 10 commits into
eamonn-zh wants to merge 10 commits into
Conversation
Contributor
|
(There's no need to keep merging from main. There are no conflicts afaict.) This could be a useful addition - do you have an application? My concern here is that it makes builds bigger and slower, which is the opposite of where we really want pytorch3d to be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add fp16 CUDA supports for sample_farthest_points, ball_query functions via
AT_DISPATCH_FLOATING_TYPES_AND_HALFand knn