Pytorch3D can build and run on AMD GPUs#2022
Conversation
Remove USE_ROCM preprocessor guards around float3 operators in pulsar math.h so they are available when building with ROCm/HIP on AMD GPUs. Made-with: Cursor
Restore #if !defined(USE_ROCM) guard covering ALL float3 operators (binary and compound-assignment). On ROCm, float3 is HIP_vector_type<float, 3> which already provides these operators as member functions; defining them as free functions too causes ambiguous overload errors at compile time. The guard also now covers +=, -=, *=, /= which were previously unguarded. Made-with: Cursor
|
Hi @ZJLi2013! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
built and run verified on MI300, gfx942,
test logs:
test.log