Security: Unsafe reinterpret_cast of raw pointer without size or alignment validation#2034
Conversation
In `norm_cam_gradients`, `renderer.grad_cam_d` (a raw float pointer) is reinterpret_cast to `CamGradInfo*` without any validation that the underlying memory is correctly sized or aligned for `CamGradInfo`. If the allocated buffer for `grad_cam_d` is smaller than `sizeof(CamGradInfo)`, this leads to out-of-bounds memory access. Similarly, misalignment could cause undefined behavior on certain platforms. Affected files: renderer.norm_cam_gradients.device.h Signed-off-by: Trần Bách <45133811+barttran2k@users.noreply.github.com>
|
Hi @barttran2k! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
1 participant
Problem
In
norm_cam_gradients,renderer.grad_cam_d(a raw float pointer) is reinterpret_cast toCamGradInfo*without any validation that the underlying memory is correctly sized or aligned forCamGradInfo. If the allocated buffer forgrad_cam_dis smaller thansizeof(CamGradInfo), this leads to out-of-bounds memory access. Similarly, misalignment could cause undefined behavior on certain platforms.Severity:
mediumFile:
pytorch3d/csrc/pulsar/include/renderer.norm_cam_gradients.device.hSolution
Add a static_assert or runtime check ensuring
sizeof(CamGradInfo)matches the expected buffer size, and that alignment requirements are satisfied.Changes
pytorch3d/csrc/pulsar/include/renderer.norm_cam_gradients.device.h(modified)Testing