Skip to content

Security: Unsafe reinterpret_cast of raw pointer without size or alignment validation #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barttran2k wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Security: Unsafe reinterpret_cast of raw pointer without size or alignment validation #2034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pytorch3d/csrc/pulsar/include/renderer.norm_cam_gradients.device.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ namespace Renderer {
template <bool DEV>
GLOBAL void norm_cam_gradients(Renderer renderer) {
GET_PARALLEL_IDX_1D(idx, 1);
static_assert(
sizeof(CamGradInfo) % sizeof(float) == 0,
"CamGradInfo size must be a multiple of sizeof(float).");
static_assert(
alignof(CamGradInfo) <= alignof(float),
"CamGradInfo alignment must not exceed float alignment.");
CamGradInfo* cgi = reinterpret_cast<CamGradInfo*>(renderer.grad_cam_d);
*cgi = *cgi * FRCP(static_cast<float>(*renderer.n_grad_contributions_d));
END_PARALLEL_NORET();
Expand Down