Improve modern packaging compatibility for local source builds#2037
Open
han-xudong wants to merge 2 commits into
Open
Improve modern packaging compatibility for local source builds#2037han-xudong wants to merge 2 commits into
han-xudong wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2036
Summary
This PR improves PyTorch3D compatibility with modern Python packaging workflows.
Changes
pyproject.tomlusingsetuptools.build_metapyproject.tomlauthors,optional-dependencies, andscriptsasdynamicsetup.pyfrom absolute paths to paths relative to the project rootWhy
Modern build frontends are stricter than legacy
setup.py installflows.In particular:
pyproject.tomlThese changes improve packaging compatibility without changing the runtime API.
Validation
Validated with a local source install through
uvusing a matching PyTorch / CUDA combination:This completed successfully and built
pytorch3dfrom local source.