Skip to content

Commit b4dc0ad

Browse files
authored
Merge pull request #35 from tstirrat15/master
Add defer to script tags for loading purposes
2 parents e9de83a + fc9e02a commit b4dc0ad

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

__tests__/__snapshots__/createApiWithCss.test.js.snap

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@
33
exports[`createApiWithCss() generates js + style components, strings and arrays 1`] = `
44
<span>
55
<script
6+
defer={true}
67
src="/static/0.js"
78
type="text/javascript"
89
/>
910
<script
11+
defer={true}
1012
src="/static/main.js"
1113
type="text/javascript"
1214
/>
@@ -38,8 +40,8 @@ exports[`createApiWithCss() generates js + style components, strings and arrays
3840
`;
3941

4042
exports[`createApiWithCss() generates js + style components, strings and arrays 4`] = `
41-
"<script type='text/javascript' src='/static/0.js'></script>
42-
<script type='text/javascript' src='/static/main.js'></script>"
43+
"<script type='text/javascript' src='/static/0.js' defer></script>
44+
<script type='text/javascript' src='/static/main.js' defer></script>"
4345
`;
4446

4547
exports[`createApiWithCss() generates js + style components, strings and arrays 5`] = `
@@ -71,6 +73,7 @@ Array [
7173
exports[`createApiWithCss() uses files with extension "no_css.js" if available 1`] = `
7274
<span>
7375
<script
76+
defer={true}
7477
src="/static/main.no_css.js"
7578
type="text/javascript"
7679
/>
@@ -95,7 +98,7 @@ exports[`createApiWithCss() uses files with extension "no_css.js" if available 3
9598
</span>
9699
`;
97100

98-
exports[`createApiWithCss() uses files with extension "no_css.js" if available 4`] = `"<script type='text/javascript' src='/static/main.no_css.js'></script>"`;
101+
exports[`createApiWithCss() uses files with extension "no_css.js" if available 4`] = `"<script type='text/javascript' src='/static/main.no_css.js' defer></script>"`;
99102

100103
exports[`createApiWithCss() uses files with extension "no_css.js" if available 5`] = `"<link rel='stylesheet' href='/static/main.css' />"`;
101104

src/createApiWithCss.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ export default (
5555
type='text/javascript'
5656
src={`${publicPath}/${file}`}
5757
key={key}
58+
defer
5859
/>
5960
))}
6061
</span>
@@ -74,7 +75,7 @@ export default (
7475
scripts
7576
.map(
7677
file =>
77-
`<script type='text/javascript' src='${publicPath}/${file}'></script>`
78+
`<script type='text/javascript' src='${publicPath}/${file}' defer></script>`
7879
)
7980
.join('\n')
8081
},

0 commit comments

Comments
 (0)