[Draft] Feature: Add alternate copy paste with raw curve values.#1332
Draft
DavidJKeizer wants to merge 3 commits intoPlotJuggler:mainfrom
Draft
[Draft] Feature: Add alternate copy paste with raw curve values.#1332DavidJKeizer wants to merge 3 commits intoPlotJuggler:mainfrom
DavidJKeizer wants to merge 3 commits intoPlotJuggler:mainfrom
Conversation
This allows us to retrieve the raw value that is displayed by the cell, which will enable a better copy/paste functionality. Previously, we were restricted to querying the display string which is restricting when it comes to formatting and parsing. Note: the RawValue is stored as a QVariant because we need to be able to fall back to a string in the event that the series is not numeric data.
It is frequently useful to copy the raw value from the plot at a given moment in time. For an example, the latitude and longitude have more context on an external map. Rather than have the user manually read and re-enter the values, they can now just use Alt-C to copy the name and value for all selected fields to their clipboard. Note: Ctrl-C was left untouched to avoid breaking any muscle memory for users who used the existing copy and paste functionality to filter the available curves.
Author
|
CI/CD is failing, so I have marked this as draft until I can look at it again. I also want to add a setting to configure default copy/paste behavior. |
DavidJKeizer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
In the curve list panel, the current copy shortcut simply copies the source path for the series. This can be used to search for a series in the list.
Pressing (Ctrl + C) on gps_quality_poor copies the following to the clipboard:
estimator_event_flags.02/gps_quality_poorPresent Restrictions
While functional, there are times where copy the series name and its value to the clipboard is preferable. Consider the case where a latitude and longitude pair must be cross-referenced with a map. Presently, there is no convenient method available to do this. In the example case of GPS coordinates, the number of digits of prevision that plot juggler shows may also be insufficient.
New Feature
This PR adds a new keyboard shortcut (Alt + C) which appends all selected series and their complete raw values to the clipboard.
This allows users to see the raw values, and manipulate them as needed for use in other software.
A new shortcut was chosen to be added instead of modifying the existing copy behavior to prevent breaking the current copy -> search behavior.
In the above example (Alt + C) will copy the following to the clipboard:
Testing
The PR has been built and tested on Windows 11 with vcpkg, as well as with Ubuntu 24.04 LTS in WSL using the docker container.
Change Log Entry