fix: add comment on event propagation#161
Open
nicir wants to merge 3 commits into
Open
Conversation
…nts and not to "created" events. Also no parent propagation.
Contributor
Author
arnoweiss
requested changes
Jun 9, 2026
arnoweiss
left a comment
arnoweiss
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the pitch. Some general comments, I think we don't have to change as much as proposed.
|
|
||
| Events are emitted on the resource level directly addressed by the operation. | ||
| Changes MUST NOT automatically propagate to parent resources. | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| Events MAY be emitted by the more low-level resources. |
| | Asset Administration Shell object* | Status code* | | ||
| | | Replaced Asset Administration Shell | | ||
|
|
||
| <!-- |
Contributor
There was a problem hiding this comment.
I don't understand the rationale behind removal of these Events - there could still be HTTP calls like PUT /shells. Shouldn't those still emit events regardless of changes in the underlying submodels?
| | Reference to the Submodel* | Status code* | | ||
| | | Created Submodel Reference* | | ||
|
|
||
| _Note: Creation or deletion of a Submodel itself does not imply an AAS update event unless the AAS Submodel reference list is modified._ |
| _("*" indicates a mandatory parameter)_ | ||
| _Note: Changes to contained SMEs do not by themselves require a SubmodelUpdated event when the operation addresses a SubmodelElement endpoint._ | ||
|
|
||
| _When a **PutSubmodel** operation replaces an existing Submodel, a SubmodelUpdated event MUST be emitted. |
Contributor
There was a problem hiding this comment.
Replacing, I think, would mean "one id stops existing, the other one comes into existence". A PUT operation that has contradicting ids in path and body however will always return HTTP 4xx so I think the scenario doesn't exist.
| Additional SubmodelElementCreated, SubmodelElementUpdated, or SubmodelElementDeleted events MUST NOT be emitted._ | ||
|
|
||
| <!-- If a new SubmodelElement is created (PostSubmodelElement) or deleted (DeleteSubmodelElementByPath), does this update the Submodel itself? --> | ||
| _When a **PutSubmodel** operation creates a new SM, a SubmodelUpdated event MUST be emitted, not a SubmodelCreated event. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Minor Wording Changes in the Spec.
WHY
Inaccuracies in the text.
FURTHER NOTES
None.