fix(agdatabase): drop sync state (#94)

* fix(agdatabase): drop sync state

Author: alexirion10

src/AgDatabase.cs

@@ -89,9 +89,6 @@ public bool Exists()
     /// </summary>
     public void Delete()
     {
-      // Deleting the database while it is initializing will leave it in a state where system redo threads are stuck.
-      // This leaves the database in a state that a SQL Server service restart prior to deletion.
-      _listener.ForEachAgInstance(WaitForInitialization);
       _listener.AvailabilityGroup.Remove(Name);
       _listener.ForEachAgInstance(s => s.Database(Name)?.Drop());
     }
@@ -156,7 +153,7 @@ public void DropLogin(LoginProperties login)
 
     public void DropAllLogins()
     {
-      foreach(var loginProp in AssociatedLogins()) DropLogin(loginProp);
+      _listener.ForEachAgInstance(s => s.Database(Name)?.DropAssociatedLogins());
     }
 
     public void AddLogin(LoginProperties login)
@@ -187,18 +184,6 @@ public void FullBackup()
       _listener.Primary.FullBackup(Name, _backupPathSqlQuery);
     }
 
-    private void WaitForInitialization(Server server, AvailabilityGroup availabilityGroup)
-    {
-      var policy = Policy
-        .Handle<TimeoutException>()
-        .WaitAndRetry(4, retryAttempt => TimeSpan.FromMilliseconds(Math.Pow(10, retryAttempt)));
-
-      policy.Execute(() => {
-        if(availabilityGroup.IsInitializing(Name))
-          throw new TimeoutException($"{server.Name} is initializing. Wait period expired.");
-      });
-    }
-
     public void FinalizePrimary()
     {
       _listener.ForEachAgInstance(FinalizePrimary);

src/SmoFacade/AvailabilityGroup.cs

@@ -64,9 +64,19 @@ public bool IsInitializing(string dbName)
         .SingleOrDefault(d => d.Name.Equals(dbName, StringComparison.InvariantCultureIgnoreCase));
       if(availabilityDatabase == null)
         return false;
+
       availabilityDatabase.Refresh();
 
-      return availabilityDatabase.SynchronizationState == MsftSmo.AvailabilityDatabaseSynchronizationState.Initializing;
+      try {
+        return availabilityDatabase.SynchronizationState ==
+               MsftSmo.AvailabilityDatabaseSynchronizationState.Initializing;
+      }
+      catch(
+        MsftSmo.PropertyCannotBeRetrievedException) { } // good here, AvailabilityDatabaseSynchronizationState unavailable means it has no state
+      catch(MsftSmo.SmoException e) when(e.Message.Contains("Cannot access properties or methods")) { }
+      catch(Exception) { return true; }
+
+      return false;
     }
   }
 }

src/SmoFacade/Database.cs

@@ -40,6 +40,17 @@ public void RestoreWithRecovery()
       _database.Refresh();
     }
 
+    public void DropAssociatedLogins()
+    {
+      var logins = Users.Where(u => u.Login != null && u.Login.Name != "sa")
+        .Select(u => u.Login.Properties());
+      foreach(var login in logins) {
+        _server.DropLogin(new LoginProperties() {
+          Name = login.Name
+        });
+      }
+    }
+
     /// <summary>
     ///   Kills connections and deletes the database.
     /// </summary>
@@ -120,6 +131,10 @@ public void MultiUserMode()
 
     private void ThrowIfUnreadyToDrop()
     {
+      // Deleting the database while it is initializing will leave it in a state where system redo threads are stuck.
+      // This leaves the database in a state that a SQL Server service restart prior to deletion.
+
+
       var policyPrep = Policy
         .Handle<Exception>()
         .WaitAndRetry(3, retryAttempt => TimeSpan.FromMilliseconds(Math.Pow(10, retryAttempt)));