feat(login): create new sql login (#96)

* feat(login): create new sql login

* feat(tests): integration

* fix(tests): review

* fix(test-dispose): review

Author: mja9

src/AgDatabase.cs

@@ -12,9 +12,13 @@ namespace AgDatabaseMove
   using System.Data.SqlClient;
   using System.Linq;
   using System.Threading;
+  using System.Threading.Tasks;
   using Exceptions;
+  using Microsoft.SqlServer.Management.Smo;
   using Polly;
   using SmoFacade;
+  using AvailabilityGroup = SmoFacade.AvailabilityGroup;
+  using Server = SmoFacade.Server;
 
 
   public interface IAgDatabase
@@ -158,7 +162,19 @@ public void DropAllLogins()
 
     public void AddLogin(LoginProperties login)
     {
-      _listener.ForEachAgInstance(server => server.AddLogin(login));
+      if (login.LoginType == LoginType.SqlLogin && login.Sid == null) {
+        AddNewSqlLogin(login);
+      } 
+      else {
+        _listener.ForEachAgInstance(server => server.AddLogin(login));
+      }
+    }
+
+    private void AddNewSqlLogin(LoginProperties login)
+    {
+      var createdLogin = _listener.Primary.AddLogin(login);
+      login.Sid = createdLogin.Sid;
+      Parallel.ForEach(_listener.Secondaries, server => server.AddLogin(login));
     }
 
     public IEnumerable<RoleProperties> AssociatedRoles()

src/SmoFacade/Login.cs

@@ -123,6 +123,7 @@ private static Microsoft.SqlServer.Management.Smo.Login ConstructLogin(LoginProp
       else {
         login.Create();
       }
+      login.Refresh();
 
       return login;
     }

src/SmoFacade/Server.cs

@@ -278,11 +278,11 @@ private void Backup(Backup backup, string backupDirectoryPathQuery, string datab
       backup.SqlBackup(_server);
     }
 
-    public void AddLogin(LoginProperties login)
+    public Login AddLogin(LoginProperties login)
     {
       var matchingLogin =
         Logins.SingleOrDefault(l => l.Name.Equals(login.Name, StringComparison.InvariantCultureIgnoreCase));
-      if(matchingLogin == null) matchingLogin = new Login(login, this);
+      return matchingLogin ?? new Login(login, this);
     }
 
     public void AddRole(LoginProperties login, RoleProperties role)

tests/AgDatabaseMove.Integration/Config/TestAgDatabaseConfig.cs

@@ -0,0 +1,10 @@
+namespace AgDatabaseMove.Integration.Config
+{
+  public class TestAgDatabaseConfig
+  {
+    public string ConnectionString { get; set; }
+    public string DatabaseName { get; set; }
+    public string BackUpPathSqlQuery { get; set; }
+    public string CredentialName { get; set; }
+  }
+}

tests/AgDatabaseMove.Integration/Fixtures/TestAgDatabaseFixture.cs

@@ -0,0 +1,62 @@
+namespace AgDatabaseMove.Integration.Fixtures
+{
+  using Config;
+  using System;
+  using System.Collections.Generic;
+  using Microsoft.SqlServer.Management.Smo;
+  using SmoFacade;
+  using System.Linq;
+
+  public class TestAgDatabaseFixture : IDisposable
+  {
+    public readonly TestAgDatabaseConfig _agConfig =
+      new TestConfiguration<TestAgDatabaseConfig>("TestAgDatabase")._config;
+
+    public readonly TestLoginConfig _loginConfig =
+      new TestConfiguration<TestLoginConfig>("TestLogin")._config;
+
+    public AgDatabase _agDatabase;
+
+    public IEnumerable<SmoFacade.Login> _createdLogins;
+
+    public TestAgDatabaseFixture()
+    {
+      _agDatabase = new AgDatabase(new DatabaseConfig
+      {
+        BackupPathSqlQuery = _agConfig.BackUpPathSqlQuery,
+        ConnectionString = _agConfig.ConnectionString,
+        DatabaseName = _agConfig.DatabaseName,
+        CredentialName = _agConfig.CredentialName
+      });
+      _agDatabase.AddLogin(new LoginProperties
+      {
+        Name = _loginConfig.LoginName,
+        Password = _loginConfig.Password,
+        LoginType = LoginType.SqlLogin,
+        DefaultDatabase = _loginConfig.DefaultDatabase
+      });
+
+      _createdLogins = GetCreatedLogins();
+    }
+
+    private IEnumerable<SmoFacade.Login> GetCreatedLogins()
+    {
+      List<SmoFacade.Login> logins = new List<SmoFacade.Login>();
+      logins.Add(_agDatabase._listener.Primary.Logins
+                   .SingleOrDefault(l => l.Name.Equals(_loginConfig.LoginName, StringComparison.InvariantCultureIgnoreCase)));
+      foreach (var server in _agDatabase._listener.Secondaries)
+      {
+        logins.Add(server.Logins
+                     .SingleOrDefault(l => l.Name.Equals(_loginConfig.LoginName, StringComparison.InvariantCultureIgnoreCase)));
+      }
+
+      return logins;
+    }
+
+    public void Dispose()
+    {
+      _agDatabase?.DropLogin(new LoginProperties { Name = _loginConfig.LoginName });
+      _agDatabase?.Dispose();
+    }
+  }
+}

tests/AgDatabaseMove.Integration/TestAgDatabase.cs

@@ -0,0 +1,29 @@
+namespace AgDatabaseMove.Integration
+{
+  using System.Linq;
+  using Xunit;
+  using Fixtures;
+
+  public class TestAgDatabase : IClassFixture<TestAgDatabaseFixture>
+  {
+    private readonly TestAgDatabaseFixture _fixture;
+
+    public TestAgDatabase(TestAgDatabaseFixture testAgDatabaseFixture)
+    {
+      _fixture = testAgDatabaseFixture;
+    }
+
+    [Fact]
+    public void TestLoginsExist()
+    {
+      _fixture._agDatabase.ContainsLogin(_fixture._loginConfig.LoginName);
+    }
+
+    [Fact]
+    public void TestLoginSidsMatch()
+    {
+      var sid = _fixture._createdLogins.First().Sid;
+      Assert.All(_fixture._createdLogins.Select(l => l.Sid), s => Assert.Equal(s, sid));
+    }
+  }
+}