revert(java): synchronized function

Author: dgawande12

README.md

@@ -187,7 +187,7 @@ The `ConfidentialClient` refreshes access tokens proactively before their actual
 Default behaviour:
 - A 30 second (30,000 ms) proactive offset is applied automatically.
 - Calls to `getAccessToken()` (or `getAccessToken(false)`) reuse the cached token while it is still considered valid under this adjusted expiry.
-- `getAccessToken(true)` forces a fresh token unless one was very recently refreshed (within 5 seconds) to avoid unnecessary duplicate requests from concurrent threads.
+- `getAccessToken(true)` forces a fresh token unless one was very recently refreshed (within 5 seconds) to avoid unnecessary duplicate requests.
 
 You can override the proactive offset by configuring it in `RequestOptions`:
 

src/main/java/com/factset/sdk/utils/authentication/ConfidentialClient.java

@@ -33,7 +33,7 @@
 import java.util.List;
 import java.util.Objects;
 import java.util.concurrent.TimeUnit;
-import java.time.Duration; // added for internal duration usage
+import java.time.Duration;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -194,16 +194,15 @@ protected ConfidentialClient(final Configuration config, final TokenRequestBuild
      * @throws AccessTokenException If it can't make a successful request or parse the TokenRequest.
      * @throws SigningJwsException  If the signing of the JWS fails.
      */
-    public synchronized String getAccessToken(boolean forceRefresh) throws AccessTokenException, SigningJwsException {
+    public String getAccessToken(boolean forceRefresh) throws AccessTokenException, SigningJwsException {
         if (this.isCachedTokenValid()) {
             if (!forceRefresh) {
                 LOGGER.info("Retrieved access token which expires in: {} seconds", TimeUnit.MILLISECONDS.toSeconds(this.accessTokenExpireTime - System.currentTimeMillis()));
                 return this.accessToken.toString();
             }
 
+            // Implement a grace period of 5 seconds to avoid unnecessary token refreshes
             long currentTime = System.currentTimeMillis();
-
-            // Implementing a grace period of 5 seconds to avoid unnecessary token refreshes
             boolean recentlyRefreshed = (currentTime - this.lastRefreshTime) < 5000;
             if (recentlyRefreshed) {
                 LOGGER.debug("Force refresh requested but token was recently refreshed within grace period, returning cached token");
@@ -225,13 +224,8 @@ public synchronized String getAccessToken(boolean forceRefresh) throws AccessTok
      * @throws SigningJwsException  If the signing of the JWS fails.
      */
     @Override
-    public synchronized String getAccessToken() throws AccessTokenException, SigningJwsException {
-        if (this.isCachedTokenValid()) {
-            LOGGER.info("Retrieved access token which expires in: {} seconds", TimeUnit.MILLISECONDS.toSeconds(this.accessTokenExpireTime - System.currentTimeMillis()));
-            return this.accessToken.toString();
-        }
-
-        return this.fetchAccessToken();
+    public String getAccessToken() throws AccessTokenException, SigningJwsException {
+        return getAccessToken(false);
     }
 
     private void requestProviderMetadata() throws AuthServerMetadataContentException, AuthServerMetadataException {
@@ -264,7 +258,7 @@ private void requestProviderMetadata() throws AuthServerMetadataContentException
                 new TokenRequestBuilder().uri(this.providerMetadata.getTokenEndpointURI());
     }
 
-    private synchronized boolean isCachedTokenValid() {
+    private boolean isCachedTokenValid() {
         if (this.accessToken == null) {
             return false;
         }

src/test/java/com/factset/sdk/utils/authentication/ConfidentialClientTest.java

@@ -330,29 +330,6 @@ void getAccessTokenForceRefreshThenCachedReturnsCorrectTokens() throws Exception
         verify(harness.httpRequestMock, times(1)).send();
     }
 
-    @Test
-    void getAccessTokenTwoDifferentThreadsSimultaneouslyOnlyFetchesOnce() throws Exception {
-        TestHarness harness = createClientWithTokens(899, "threadedToken");
-
-        Runnable task = () -> {
-            String token;
-            try {
-                token = harness.client.getAccessToken();
-            } catch (AccessTokenException | SigningJwsException e) {
-                throw new RuntimeException(e);
-            }
-            assertEquals("threadedToken", token);
-        };
-
-        Thread thread1 = new Thread(task);
-        Thread thread2 = new Thread(task);
-        thread1.start();
-        thread2.start();
-        thread1.join();
-        thread2.join();
-
-        verify(harness.httpRequestMock, times(1)).send();
-    }
 
     @Test
     void forceRefreshWithinGracePeriodReturnsCachedToken() throws Exception {