Skip to content

Feature/workflow fixes#10

Merged
Zalfsten merged 7 commits into
mainfrom
feature/workflow_fixes
Feb 9, 2026
Merged

Feature/workflow fixes#10
Zalfsten merged 7 commits into
mainfrom
feature/workflow_fixes

Conversation

@Zalfsten
Copy link
Copy Markdown
Contributor

@Zalfsten Zalfsten commented Feb 4, 2026

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Zalfsten, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the development workflow and build reliability across the project. It standardizes devcontainer configurations by pinning tool versions, rectifies a minor script execution error, and introduces clear code quality guidelines for agents. A significant portion of the changes refines the Docker build process for the sql_to_arc middleware, ensuring correct handling of Python dependencies and proper bundling with PyInstaller. Additionally, it centralizes dependency source definitions and updates various package versions to their latest stable releases.

Highlights

  • Devcontainer Configuration Updates: Pinned specific versions for the 'actions-runner' feature and 'dotnetVersion' in both antigravity and vscode devcontainer configurations to ensure consistent development environments.
  • Devcontainer Script Fix: Corrected a typo in the 'postCreateCommand' within the vscode devcontainer configuration, ensuring environment variables are sourced properly.
  • Code Quality Standards: Introduced new code quality standards in AGENTS.md, outlining expectations for linting tools like Ruff, Pylance, MyPy, Pylint, and Bandit, and emphasizing actual code fixes over suppression.
  • Docker Build Process Refinement: Improved the sql_to_arc Docker build process by explicitly reinstalling git dependencies (api_client, shared) and enhancing the PyInstaller command to correctly bundle metadata and use the virtual environment's Python.
  • Centralized Dependency Configuration: Centralized the uv.sources configuration for api_client and shared from middleware/sql_to_arc/pyproject.toml to the root pyproject.toml.
  • Dependency Version Updates: Updated several Python package dependencies and their corresponding lock file entries in uv.lock, including api-client, coverage, rich, ruff, and shared.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .devcontainer/antigravity/devcontainer.json
    • Updated actions-runner feature version to 2.319.1.
    • Updated dotnetVersion to 8.0.
  • .devcontainer/vscode/devcontainer.json
    • Updated actions-runner feature version to 2.319.1.
    • Updated dotnetVersion to 8.0.
    • Fixed typo in postCreateCommand for sourcing load-env.sh.
  • AGENTS.md
    • Added a new section "Code Quality Standards" outlining expectations for linting tools and issue resolution.
  • docker/Dockerfile.sql_to_arc
    • Removed HATCH_VCS_PRETEND_VERSION from uv sync and uv pip install commands.
    • Added explicit reinstallation of git dependencies (api_client, shared) using uv pip install --force-reinstall.
    • Modified PyInstaller command to use .venv/bin/python and include --copy-metadata for sql_to_arc, api_client, and shared.
    • Adjusted PyInstaller's main script path to site-packages.
  • middleware/sql_to_arc/pyproject.toml
    • Removed [tool.uv.sources] configuration for api_client and shared.
  • pyproject.toml
    • Added api_client and shared to the root [tool.uv.sources] configuration.
  • uv.lock
    • Updated api-client to version 8.1.2.dev30+gfb5d32ed3.
    • Updated coverage to version 7.13.3.
    • Updated rich to version 14.3.2.
    • Updated ruff to version 0.15.0.
    • Updated shared to version 8.1.2.dev30+gfb5d32ed3.
Activity
  • No specific activity (comments, reviews, progress) was provided in the context for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several valuable workflow improvements. Pinning versions in the devcontainer configurations enhances reproducibility, and the typo fix in postCreateCommand is a good catch. The new code quality standards in AGENTS.md and the refactoring of pyproject.toml improve project maintainability. The Dockerfile changes for the binary build are more robust, though I've noted one area for improvement regarding dependency URL duplication.

Comment thread docker/Dockerfile.sql_to_arc
@Zalfsten Zalfsten merged commit 7633cea into main Feb 9, 2026
9 checks passed
@Zalfsten Zalfsten deleted the feature/workflow_fixes branch February 9, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant