Feature/going sdd by Zalfsten · Pull Request #35 · fairagro/m4.2_sql_to_arc

Zalfsten · 2026-04-09T13:29:23Z

No description provided.

…ARC building, database access, demo environment, and SQL-to-ARC conversion

…se access, demo environment, and SQL-to-ARC conversion

…and updating related functions for improved type safety and clarity

…ify annotation table streaming and connection string handling

… contract and requirements

…t_type fields to use Literal types for improved type safety

…and performance tuning; remove outdated architectural documentation

…ensions and obsolete architecture rules documentation

gemini-code-assist

Code Review

This pull request introduces a formal Pydantic model, AnnotationTableRow, to replace raw dictionary handling for annotation table data. It updates the database streaming, builder logic, and processor to use this typed model, improving type safety and validation. Additionally, it adds a warning for assays missing linked studies, refines the AnnotationTableRow validation, updates the demo environment documentation, and removes unused mapper code and redundant documentation.

…r structure, file requirements, and registration in AGENTS.md

- Introduced `ai_workflow.md` detailing the integration of AI coding agents, project structure, and VS Code integration. - Documented the entry point for agents in `AGENTS.md`, emphasizing its role in providing project context. - Explained the spec-driven development approach with a two-level layout for specs in `spec/` and `middleware/*/spec/`. - Outlined the use of agent skills in `.agents/skills/`, including discovery, activation, and execution processes. - Provided practical workflow examples for agents, including adding new config fields and fixing serialization bugs. - Added new specs and design documents for API upload, ARC building, database access, and SQL-to-ARC conversion. - Established principles for the FAIRagro SQL-to-ARC project, emphasizing correctness, memory safety, and security. - Created demo environment specifications to facilitate local testing without external dependencies.

…sql_to_arc into feature/going-sdd

… code

Zalfsten · 2026-04-13T16:29:41Z

/gemini review

gemini-code-assist

Code Review

This pull request establishes a spec-driven development framework by introducing Specifica feature specifications, AI agent skills, and a formalized AI workflow. The core logic for processing annotation tables has been refactored to use a typed AnnotationTableRow Pydantic model, replacing raw dictionary handling and improving type safety across the builder, database, and processor modules. Additionally, the developer environment and project documentation have been cleaned up, including the removal of redundant architectural guides and unused VS Code extensions. Feedback highlights opportunities to refine error handling severity and optimize the placement of logging within data validation logic.

Zalfsten · 2026-04-13T16:52:07Z

/gemini review

gemini-code-assist

Code Review

This pull request establishes a robust, spec-driven architecture for the SQL-to-ARC converter by introducing Specifica-compliant feature documentation, custom AI agent configurations, and reusable 'Agent Skills' for library usage. Significant refactoring was performed in the sql_to_arc component to replace raw dictionary processing with a typed AnnotationTableRow model, enhancing type safety during database streaming and ARC construction. Review feedback identifies a mismatch between the column_io_type literal values and the supported arctrl IO types, highlights undefined variables in documentation code snippets, and points out several incorrect relative links in the newly added Markdown files.

gemini-code-assist · 2026-04-13T16:55:33Z

+    table_name: str = spec_field()
+    column_type: str = spec_field()
+    row_index: int = spec_field()
+    column_io_type: Literal["data", "material_name", "sample_name", "source_name"] | None = spec_field(default=None)


The Literal type for column_io_type includes values ("data", "material_name") that do not seem to align with the known strings for IOType.of_string in the arctrl library, as documented in .agents/skills/arctrl/SKILL.md. The skill file lists "source_name", "sample_name", "raw_data_file", "derived_data_file", "image_file", and "material".

Using unsupported values like "data" (as seen in integration tests) could lead to runtime errors when arctrl attempts to process them. Please align the Literal values with those supported by arctrl to ensure correctness.

Suggested change

column_io_type: Literal["data", "material_name", "sample_name", "source_name"] | None = spec_field(default=None)

column_io_type: Literal["source_name", "sample_name", "raw_data_file", "derived_data_file", "image_file", "material"] | None = spec_field(default=None)

gemini-code-assist · 2026-04-13T16:55:34Z

+if header.IsTermColumn:
+    cell = CompositeCell.term(OntologyAnnotation(str(value), "", ""))
+else:
+    cell = CompositeCell.free_text(str(value))


The variable value used in this example code block is not defined, which could be confusing for a user or an AI agent trying to understand the example. Please define it to make the snippet self-contained and clearer.

Suggested change

if header.IsTermColumn:

cell = CompositeCell.term(OntologyAnnotation(str(value), "", ""))

else:

cell = CompositeCell.free_text(str(value))

value = "some_value"

if header.IsTermColumn:

cell = CompositeCell.term(OntologyAnnotation(str(value), "", ""))

else:

cell = CompositeCell.free_text(str(value))

gemini-code-assist · 2026-04-13T16:55:34Z

+
+```python
+mocker.patch("mycomponent.main.ConfigWrapper.from_yaml_file")
+mocker.patch("mycomponent.main.Config.from_config_wrapper", return_value=mock_config)


The variable mock_config used in this example is not defined. To make the example self-contained and easier to understand, please provide a definition for it.

Suggested change

mocker.patch("mycomponent.main.Config.from_config_wrapper", return_value=mock_config)

mock_config = Config(connection_string=SecretStr("..."), batch_size=10) # Example config

mocker.patch("mycomponent.main.Config.from_config_wrapper", return_value=mock_config)

gemini-code-assist · 2026-04-13T16:55:34Z

+## 7. Project Conventions
+
+These rules apply specifically to this project (see also
+[`spec/principles.md`](../../../spec/principles.md)):


The relative link to spec/principles.md appears to be incorrect. Given the file's location at .agents/skills/create-specifica-feature/SKILL.md, the path should navigate up four levels to the repository root.

Suggested change

[`spec/principles.md`](../../../spec/principles.md)):

[`spec/principles.md`](../../../../spec/principles.md)):

gemini-code-assist · 2026-04-13T16:55:34Z

+
+## Step 1 — Load project context
+
+Read [`AGENTS.md`](../../AGENTS.md) to get the project's tech stack,


The relative link to AGENTS.md appears to be incorrect. From the current file's location, it should navigate up three levels to reach the repository root.

Suggested change

Read [`AGENTS.md`](../../AGENTS.md) to get the project's tech stack,

Read [`AGENTS.md`](../../../AGENTS.md) to get the project's tech stack,

gemini-code-assist · 2026-04-13T16:55:34Z

+
+The authoritative column-level specification for all views — including
+required/optional fields, data types, and cross-dialect type mappings — is
+maintained in [docs/sql_to_arc_database_views.md](../../../../docs/sql_to_arc_database_views.md).


The relative link to docs/sql_to_arc_database_views.md appears to be incorrect. Given this file's location, the path needs to navigate up five levels to reach the repository root.

Suggested change

maintained in [docs/sql_to_arc_database_views.md](../../../../docs/sql_to_arc_database_views.md).

maintained in [docs/sql_to_arc_database_views.md](../../../../../docs/sql_to_arc_database_views.md).

Zalfsten · 2026-04-13T17:28:49Z

/gemini review

… and CI

gemini-code-assist

Code Review

This pull request introduces a comprehensive AI-agent-friendly documentation and workflow system based on the Specifica and Agent Skills standards. It reorganizes architectural documentation into structured feature folders containing requirement specs and design decisions, while providing on-demand procedural knowledge for libraries like arctrl. On the implementation side, the annotation table processing has been refactored to use a typed AnnotationTableRow Pydantic model instead of raw dictionaries, improving type safety and consistency across the pipeline. Additionally, support for Data cells in ARC tables was added, and tooling configurations for VS Code, Ruff, and Mypy were updated to align with the new project structure. I have no feedback to provide as all review comments were filtered out.

Zalfsten and others added 9 commits April 9, 2026 11:36

Add comprehensive design and specification documents for API upload, …

632b679

…ARC building, database access, demo environment, and SQL-to-ARC conversion

Remove outdated design documents for API upload, ARC building, databa…

6f26a5b

…se access, demo environment, and SQL-to-ARC conversion

Refactor annotation handling by introducing AnnotationTableRow model …

36f6b75

…and updating related functions for improved type safety and clarity

Update design and specification documents for database access to clar…

3b4843e

…ify annotation table streaming and connection string handling

Refactor API upload design and specification documents to clarify API…

5a3bb86

… contract and requirements

Enhance validation and logging for ARC building process; update targe…

d22ab6d

…t_type fields to use Literal types for improved type safety

Update design documents to enhance clarity on pipeline orchestration …

12d6de9

…and performance tuning; remove outdated architectural documentation

Merge branch 'main' into feature/going-sdd

0650ec8

Refactor devcontainer and extensions configuration; remove unused ext…

36e262b

…ensions and obsolete architecture rules documentation

gemini-code-assist Bot reviewed Apr 9, 2026

View reviewed changes

Zalfsten added 4 commits April 13, 2026 15:59

Add step-by-step guide for creating Specifica features; include folde…

b2a5fa5

…r structure, file requirements, and registration in AGENTS.md

Merge branch 'feature/going-sdd' of https://github.com/fairagro/m4.2_…

1a5c742

…sql_to_arc into feature/going-sdd

feat: Add spec-to-code agent for translating spec changes into source…

e339190

… code

gemini-code-assist Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread middleware/sql_to_arc/src/middleware/sql_to_arc/builder.py

Comment thread middleware/sql_to_arc/src/middleware/sql_to_arc/models.py Outdated

feat: Add default handling for missing column_io_type in header building

cdfeac0

gemini-code-assist Bot reviewed Apr 13, 2026

View reviewed changes

feat: Enhance IOType mapping and documentation for arctrl integration

40a3605

feat: Add tooling consistency specifications for VS Code, pre-commit,…

918927a

… and CI

Zalfsten marked this pull request as ready for review April 13, 2026 17:31

gemini-code-assist Bot reviewed Apr 13, 2026

View reviewed changes

Zalfsten merged commit 2038f45 into main Apr 13, 2026
9 checks passed

Zalfsten deleted the feature/going-sdd branch April 13, 2026 17:39

	column_io_type: Literal["data", "material_name", "sample_name", "source_name"] \| None = spec_field(default=None)
	column_io_type: Literal["source_name", "sample_name", "raw_data_file", "derived_data_file", "image_file", "material"] \| None = spec_field(default=None)

	mocker.patch("mycomponent.main.Config.from_config_wrapper", return_value=mock_config)
	mock_config = Config(connection_string=SecretStr("..."), batch_size=10) # Example config
	mocker.patch("mycomponent.main.Config.from_config_wrapper", return_value=mock_config)

	[`spec/principles.md`](../../../spec/principles.md)):
	[`spec/principles.md`](../../../../spec/principles.md)):


		## Step 1 — Load project context

		Read [`AGENTS.md`](../../AGENTS.md) to get the project's tech stack,

	Read [`AGENTS.md`](../../AGENTS.md) to get the project's tech stack,
	Read [`AGENTS.md`](../../../AGENTS.md) to get the project's tech stack,

	maintained in [docs/sql_to_arc_database_views.md](../../../../docs/sql_to_arc_database_views.md).
	maintained in [docs/sql_to_arc_database_views.md](../../../../../docs/sql_to_arc_database_views.md).

Conversation

Zalfsten commented Apr 9, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Zalfsten commented Apr 13, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Zalfsten commented Apr 13, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Zalfsten commented Apr 13, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant