fix: 🐛 handling of apply license template with custom licenses

Author: slugb0t

bot/compliance-checks/license/index.js

@@ -17,11 +17,7 @@ const CODEFAIR_DOMAIN = process.env.CODEFAIR_APP_DOMAIN;
  * @returns {boolean} - Returns true if a license is found in the repository, false otherwise
  */
 export async function checkForLicense(context, owner, repoName) {
-  const licenseFilesTypes = [
-    "LICENSE",
-    "LICENSE.md",
-    "LICENSE.txt",
-  ];
+  const licenseFilesTypes = ["LICENSE", "LICENSE.md", "LICENSE.txt"];
 
   for (const filePath of licenseFilesTypes) {
     const file = await checkForFile(context, owner, repoName, filePath);
@@ -137,8 +133,8 @@ export async function updateLicenseDatabase(repository, license) {
         license_content: licenseContent,
         custom_license_title:
           licenseId === "Custom"
-            ? licenseId
-            : existingLicense.custom_license_title,
+            ? existingLicense.custom_license_title
+            : "",
       },
       where: { repository_id: repository.id },
     });
@@ -153,7 +149,7 @@ export async function updateLicenseDatabase(repository, license) {
         license_status: licenseContentEmpty ? "invalid" : "valid",
         license_id: licenseId,
         license_content: licenseContent,
-        custom_license_title: licenseId === "Custom" ? licenseId : "",
+        custom_license_title: "",
         repository: {
           connect: {
             id: repository.id,
@@ -194,17 +190,9 @@ export async function applyLicenseTemplate(
 
   if (subjects.license.status && licenseId && licenseId !== "Custom") {
     baseTemplate += `## LICENSE ✔️\n\nA \`LICENSE\` file is found at the root level of the repository.\n\n${licenseBadge}\n\n`;
-  } else if (
-    subjects.license.status &&
-    licenseId === "Custom" &&
-    customTitle === ""
-  ) {
+  } else if (subjects.license.status && licenseId === "Custom" && !customTitle) {
     baseTemplate += `## LICENSE ❗\n\nA custom \`LICENSE\` file has been found at the root level of this repository.\n > [!NOTE]\n> While using a custom license is normally acceptable for Zenodo, please note that Zenodo's API currently cannot handle custom licenses. If you plan to make a FAIR release, you will be required to select a license from the SPDX license list to ensure proper archival and compliance.\n\nClick the "Edit license" button below to provide a license title or to select a new license.\n\n${licenseBadge}\n\n`;
-  } else if (
-    subjects.license.status &&
-    licenseId === "Custom" &&
-    customTitle !== ""
-  ) {
+  } else if (subjects.license.status && licenseId === "Custom" && customTitle) {
     baseTemplate += `## LICENSE ✔️\n\nA custom \`LICENSE\` file titled as **${customTitle}**, has been found at the root level of this repository. If you would like to update the title or change license, click the "Edit license" button below.\n\n${licenseBadge}\n\n`;
   } else {
     baseTemplate += `## LICENSE ❌\n\nTo make your software reusable, a \`LICENSE\` file is expected at the root level of your repository.\nIf you would like Codefair to add a license file, click the "Add license" button below to go to our interface for selecting and adding a license. You can also add a license file yourself, and Codefair will update the dashboard when it detects it on the main branch.\n\n${licenseBadge}\n\n`;