feat: add asset downloads + change soda for sparc -> SODA#683
Conversation
|
Thank you for submitting this pull request! We appreciate your contribution to the project. Before we can merge it, we need to review the changes you've made to ensure they align with our code standards and meet the requirements of the project. We'll get back to you as soon as we can with feedback. Thanks again! |
Reviewer's GuideThis PR enhances the Impact component by updating and extending its metrics display, renames all UI references from “SODA for SPARC” to “SODA” across the app, and refreshes descriptive content, SEO metadata, and timeline entries to reflect the new branding and upcoming development phases. Updated Class Diagram for the Impact ComponentclassDiagram
class Impact {
<<Functional Component>>
- filesNum: Number
- datasetsNum: Number
- dataNum: Number
- assetDownloads: Number
+ render(): void
}
Class Diagram for SodaForSparcPage Timeline UpdateclassDiagram
class TimelineEntry {
+longDate: String
+title: String
+content: String
}
class SodaForSparcPage {
<<Page Component>>
- timelineList: TimelineEntry[]
+ renderPageContent(): void
}
SodaForSparcPage "1" -- "0..*" TimelineEntry : has
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for making updates to your pull request. Our team will take a look and provide feedback as soon as possible. Please wait for any GitHub Actions to complete before editing your pull request. If you have any additional questions or concerns, feel free to let us know. Thank you for your contributions! |
📝 Changed routes:
Commit 59d6344 (https://fairdataihub-website-8m8q1o741-fairdataihub.vercel.app). |
|
Running Lighthouse audit... |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @aaronm-2112 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <p className="my-1 text-center font-lato text-5xl font-bold sm:text-4xl md:text-5xl lg:text-6xl"> | ||
| <span id="dataNum">{dataNum}</span> | ||
| <span>+ TB</span> | ||
| <span id="datasetsNum">{assetDownloads}</span> |
There was a problem hiding this comment.
suggestion: Use a unique id for the assetDownloads span to avoid collisions
Rename the id from datasetsNum to something like assetDownloads for clarity and to prevent potential DOM id conflicts.
| templateDescription="SODA is a cross-platform desktop software that helps researchers | ||
| prepare and share FAIR peripheral nervous system (PNS) related data | ||
| and models using the SPARC Data Structure (SDS) and the SPARC Portal." |
There was a problem hiding this comment.
suggestion: Avoid unintended whitespace from multiline JSX string
This prop will render with unwanted line breaks and spaces; use a single line or adjust formatting to avoid extra whitespace.
| templateDescription="SODA is a cross-platform desktop software that helps researchers | |
| prepare and share FAIR peripheral nervous system (PNS) related data | |
| and models using the SPARC Data Structure (SDS) and the SPARC Portal." | |
| templateDescription="SODA is a cross-platform desktop software that helps researchers prepare and share FAIR peripheral nervous system (PNS) related data and models using the SPARC Data Structure (SDS) and the SPARC Portal." |
| { | ||
| longDate: `Sept 2023 - Aug 2024`, | ||
| title: `Phase V development`, | ||
| content: `The SODA team improved the user interfaces of SODA and enhanced workflows to further simplify data submission for non-SPARC users and worked with the MBF team for integrated MicroFile+ and Biolucida with SODA (and more).`, | ||
| }, |
There was a problem hiding this comment.
suggestion: Tighten and clarify Phase V timeline description
Update the phrase to 'to integrate MicroFile+ and Biolucida with SODA' and remove '(and more)' for clarity.
| { | |
| longDate: `Sept 2023 - Aug 2024`, | |
| title: `Phase V development`, | |
| content: `The SODA team improved the user interfaces of SODA and enhanced workflows to further simplify data submission for non-SPARC users and worked with the MBF team for integrated MicroFile+ and Biolucida with SODA (and more).`, | |
| }, | |
| { | |
| longDate: `September 2023 – August 2024`, | |
| title: `Phase V development`, | |
| content: `The SODA team improved the user interfaces of SODA and enhanced workflows to further simplify data submission for non-SPARC users and worked with the MBF team to integrate MicroFile+ and Biolucida with SODA.`, | |
| }, |
| SODA is a cross-platform desktop software that helps researchers | ||
| prepare and share FAIR peripheral nervous system (PNS) related data | ||
| and models using the SPARC Data Structure (SDS) and the SPARC Portal. |
There was a problem hiding this comment.
suggestion (typo): Hyphenate 'PNS-related' for better readability
As a compound adjective before 'data', 'PNS-related' should be hyphenated.
| SODA is a cross-platform desktop software that helps researchers | |
| prepare and share FAIR peripheral nervous system (PNS) related data | |
| and models using the SPARC Data Structure (SDS) and the SPARC Portal. | |
| SODA is a cross-platform desktop software that helps researchers | |
| prepare and share FAIR peripheral nervous system (PNS)-related data | |
| and models using the SPARC Data Structure (SDS) and the SPARC Portal. |
|
Thanks for closing this pull request! If you have any further questions, please feel free to open a new issue. We are always happy to help! |
# [2.51.0](v2.50.0...v2.51.0) (2025-06-09) ### Features * add asset downloads + change soda for sparc -> SODA ([#683](#683)) ([d8d2568](d8d2568))
|
🎉 This PR is included in version 2.51.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
3 participants
Summary by Sourcery
Add asset downloads display and update impact metrics, rebrand the application from “SODA for SPARC” to “SODA,” refresh site copy to reflect the broader PNS data focus, and expand the development timeline with Phases V and VI.
New Features:
Enhancements:
Documentation: