fix: tag LLM summary descriptionType as Other (not Abstract); drop from prompt#6
Conversation
|
Thank you for submitting this pull request! We appreciate your contribution to the project. Before we can merge it, we need to review the changes you've made to ensure they align with our code standards and meet the requirements of the project. We'll get back to you as soon as we can with feedback. Thanks again! |
Reviewer's GuideRemoves the redundant Sequence diagram for descriptionType handling in extraction pipelinesequenceDiagram
participant Extract as _generate
participant LLM
participant Postprocess as _postprocess_json
participant Client
Extract->>LLM: generate(prompt_without_descriptionType)
LLM-->>Extract: JSON(descriptions[].description)
Extract-->>Postprocess: result_json
Postprocess->>Postprocess: set descriptionType="Abstract" on each descriptions[]
Postprocess-->>Client: finalized_json
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for making updates to your pull request. Our team will take a look and provide feedback as soon as possible. Please wait for any GitHub Actions to complete before editing your pull request. If you have any additional questions or concerns, feel free to let us know. Thank you for your contributions! |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since
fundingReferencesis now explicitly called out as a remaining gap in the docs, consider adding a small in-code TODO (near the prompt JSON shape) or linking a tracking issue so the eventual prompt update forfundingReferencesdoesn’t drift out of sync with the documentation again.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since `fundingReferences` is now explicitly called out as a remaining gap in the docs, consider adding a small in-code TODO (near the prompt JSON shape) or linking a tracking issue so the eventual prompt update for `fundingReferences` doesn’t drift out of sync with the documentation again.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
7872e7d to
b7e16d5
Compare
…m prompt (0.9.15) poster2json's descriptions[] entry is a machine-generated summary, so its descriptionType is "Other". "Abstract" is reserved for the author's own formal poster abstract, which the platform attaches downstream (the submitter's abstract), never poster2json's summary. Post-processing had hardcoded descriptionType = "Abstract" since v0.9.3 (2026-06-05) -- a regression from the "Other" set on 2026-05-04 (3945d81) and reverted on 2026-05-19 (74536e8). For about three weeks every extracted summary was mislabeled as an abstract. _postprocess_json now sets "Other". Also remove descriptionType from EXTRACTION_PROMPT and FALLBACK_PROMPT: the type is set deterministically in post-processing, so asking the model for it was redundant and its value was overwritten anyway. Output stays schema-valid. The prompt-design doc update lives in the companion discussion PR, not here, so this PR is a focused code fix.
b7e16d5 to
6237384
Compare
|
Thank you for getting this pull request merged. We appreciate your contribution and look forward to your next one! |
The fix
poster2json's
descriptions[]entry is a machine-generated summary, so itsdescriptionTypemust be"Other"."Abstract"is reserved for the author's own formal poster abstract, which the platform attaches downstream (the submitter's abstract), never poster2json's summary. The field-coverage tracker says exactly this: summary ->Other, user abstract ->Abstract.Post-processing had hardcoded
descriptionType = "Abstract"since v0.9.3 (2026-06-05), a regression from the"Other"set on 2026-05-04 (3945d81) and reverted on 2026-05-19 (74536e8). So for roughly three weeks every extracted summary was mislabeled as an abstract._postprocess_jsonnow sets"Other".Also here
descriptionTypefrom the prompt. The type is set deterministically in post-processing, so asking the model for it was redundant and its value was overwritten anyway. Dropped from bothEXTRACTION_PROMPTandFALLBACK_PROMPT; output stays schema-valid (postprocess fills"Other"when the model omits it).Scope
Code-only fix. The prompt-design doc update and the open discussion live in the companion PR (#7), not here.
Tests
Non-GPU suite passes (239 passed, 1 skipped), including the
_postprocess_jsontests.Version
0.9.15 off
main(0.9.14). PosterSentry PR (#4) is rebased to 0.9.16; merge #6 before #4 to keep versions ordered.