docs: extraction prompt design and history (updated, for discussion)#7
Conversation
|
Thank you for submitting this pull request! We appreciate your contribution to the project. Before we can merge it, we need to review the changes you've made to ensure they align with our code standards and meet the requirements of the project. We'll get back to you as soon as we can with feedback. Thanks again! |
Reviewer's GuideUpdates the extraction prompt design doc to reflect that File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for making updates to your pull request. Our team will take a look and provide feedback as soon as possible. Please wait for any GitHub Actions to complete before editing your pull request. If you have any additional questions or concerns, feel free to let us know. Thank you for your contributions! |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="docs/prompt-design.md" line_range="233" />
<code_context>
v0.6.x series). DOIs, ORCIDs, arXiv IDs, ROR, and funder ids are extracted by
regex and looked up via API rather than trusted from the model.
</code_context>
<issue_to_address>
**nitpick (typo):** Consider capitalizing "ids" to "IDs" for consistency with the other identifiers listed.
To keep acronym capitalization consistent in this list, change "funder ids" to "funder IDs".
```suggestion
v0.6.x series). DOIs, ORCIDs, arXiv IDs, ROR, and funder IDs are extracted by
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -232,11 +233,13 @@ source own a field the model had been guessing. | |||
| v0.6.x series). DOIs, ORCIDs, arXiv IDs, ROR, and funder ids are extracted by | |||
There was a problem hiding this comment.
nitpick (typo): Consider capitalizing "ids" to "IDs" for consistency with the other identifiers listed.
To keep acronym capitalization consistent in this list, change "funder ids" to "funder IDs".
| v0.6.x series). DOIs, ORCIDs, arXiv IDs, ROR, and funder ids are extracted by | |
| v0.6.x series). DOIs, ORCIDs, arXiv IDs, ROR, and funder IDs are extracted by |
Bring docs/prompt-design.md up to date with current main and reopen it as a discussion. Since the original write-up merged, the prompt moved on: - publicationYear is now platform-owned (removed from the model in 0.9.14), not the lone model-owned required field as first written. - descriptionType is set deterministically to "Other" (machine summary; "Abstract" is the author's downstream abstract), and removed from the prompt. - The resolved open questions (publicationYear, descriptionType, the grounding note) are cleared; fundingReferences is recorded as a kept model field that the prompt should request. Two open questions remain for discussion: whether to add fundingReferences to the prompt, and stating the model-ownership boundary as one rule.
57d18c1 to
9ceba76
Compare
|
Thank you for getting this pull request merged. We appreciate your contribution and look forward to your next one! |
This reopens the extraction-prompt design write-up as a living discussion. The original version (#5) was merged before the discussion played out, and
mainhas since moved on, so this bringsdocs/prompt-design.mdup to date and puts the remaining questions back on the table.What this doc is
The reasoning behind the LLM extraction prompt has lived in commit messages, changelog entries, and the field-coverage tracker rather than one place. This reconciles three sources: the prompt (
EXTRACTION_PROMPT/FALLBACK_PROMPTinextract.py), the poster-json-schema contract (v0.2), and the Poster.json Field Coverage tracker (Poster Sharing sheet).Updated since #5
publicationYearis now platform-owned (removed from the model in 0.9.14), not the lone model-owned required field as first written.descriptionTypeis set deterministically toOther(machine summary;Abstractis the author's downstream abstract) and removed from the prompt (see the companion fix fix: tag LLM summary descriptionType as Other (not Abstract); drop from prompt #6).Open for discussion
fundingReferences: kept as a model field, but the prompt does not currently ask for it (postprocess only enriches funding the model volunteers). Add it to the prompt explicitly?Docs-only; no code change. The
descriptionTypevalue fix and prompt edit are in #6.Summary by Sourcery
Document the current extraction prompt design and field ownership history, reflecting that publicationYear and descriptionType are now platform-owned and deterministically set rather than model-generated.
Documentation: