fix(rds): render ModifyDBCluster fields in DescribeDBClusters#1797
Merged
Conversation
ModifyDBCluster persisted ~20 mutable cluster fields, but the DescribeDBClusters XML renderer only emitted a subset -- so a describe after a modify echoed the create-time defaults for StorageType, Iops, BacktrackWindow, IAMDatabaseAuthenticationEnabled, ServerlessV2ScalingConfiguration, the monitoring/performance-insights fields, and others. The data was in state; only the renderer lagged. Render the omitted scalar fields (string/int/bool) and the nested ServerlessV2ScalingConfiguration element, excluding the keys already emitted above so nothing double-renders. - crates/fakecloud-rds/src/extras/xml_renderers.rs - test: describe_db_clusters_renders_modified_fields
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModifyDBClusterpersisted ~20 mutable cluster fields, but theDescribeDBClustersXML renderer only emitted a subset — so a describe after a modify echoed the create-time defaults forStorageType,Iops,BacktrackWindow,IAMDatabaseAuthenticationEnabled,ServerlessV2ScalingConfiguration, the monitoring / performance-insights fields, and others. The data was already in state; only the renderer lagged (a pure render gap).Fix: render the omitted scalar fields (string/int/bool) and the nested
ServerlessV2ScalingConfigurationelement, excluding the keys already emitted so nothing double-renders.Found by the 2026-06-20 bug-hunt audit (finding 1.17).
Test plan
describe_db_clusters_renders_modified_fields— modifies StorageType/Iops/BacktrackWindow/IAM-auth/ServerlessV2 and assertsDescribeDBClustersXML now contains each.cargo clippy -p fakecloud-rds --all-targets -- -D warningsclean.Summary by cubic
Fixes
DescribeDBClustersXML to include fields updated byModifyDBCluster, so describes now reflect changes instead of create-time defaults. Adds the nestedServerlessV2ScalingConfigurationand missing scalar fields likeStorageType,Iops,BacktrackWindow, and IAM auth.ServerlessV2ScalingConfigurationfrom flattened keys.describe_db_clusters_renders_modified_fieldstest; full RDS suite passes andclippyis clean.Written for commit 3c444ea. Summary will update on new commits.