fix(ecs): apply the full mutable field set in UpdateService#1799
Merged
Conversation
UpdateService read only desiredCount, taskDefinition, and the deployment lifecycleHooks, silently dropping every other mutable field. So ECS Exec enablement, subnet/security-group changes (networkConfiguration), deployment tuning (min/max healthy percent + circuit breaker), load-balancer swaps, placement, platform version, capacity-provider strategy, propagate-tags, and managed-tags all no-op'd -- DescribeServices kept echoing the create-time values. Apply each field when present in the request (AWS partial-update semantics: an omitted field is left unchanged). All target fields already exist on the Service struct and are rendered by DescribeServices. - crates/fakecloud-ecs/src/service_services_resource.rs - test: update_service_applies_extended_fields
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateServiceread onlydesiredCount,taskDefinition, and the deploymentlifecycleHooks, silently dropping every other mutable field. So ECS Exec enablement, subnet/security-group changes (networkConfiguration), deployment tuning (min/max healthy percent + circuit breaker), load-balancer swaps, placement,platformVersion, capacity-provider strategy,propagateTags, and managed-tags all no-op'd —DescribeServiceskept echoing the create-time values.Fix: apply each field when present in the request (AWS partial-update semantics — an omitted field is left unchanged). All target fields already exist on the
Servicestruct and are rendered byDescribeServices, so this is purely wiring the reads.Found by the 2026-06-20 bug-hunt audit (finding 1.15).
Test plan
update_service_applies_extended_fields— updates enableExecuteCommand / enableECSManagedTags / healthCheckGracePeriodSeconds / platformVersion / propagateTags / networkConfiguration / deploymentConfiguration (min/max + circuit breaker) and asserts each is stored.cargo clippy -p fakecloud-ecs --all-targets -- -D warningsclean.Summary by cubic
Apply all mutable ECS service fields in UpdateService with AWS partial-update semantics. Fixes no-op updates so DescribeServices reflects changes beyond desiredCount, taskDefinition, and lifecycle hooks.
Written for commit dd4342f. Summary will update on new commits.